Repository navigation
fix(web): keep the setup wizard's subtitle credential labels readable at desktop and tablet widths - #4759
Conversation
…r labels stay readable From 40rem up, the Subtitles step put a provider's credential fields two per line. Each field is a full settings row with its label and hint beside a fixed-width input, so the label column shrank to about 50 px: "API key" wrapped onto two lines, the keep-or-replace hint ran one word per line, and the OpenSubtitles password input ran past the card's edge. Stack the fields one per line at every width, as the admin Providers page already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 32 minutes. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (no client-visible change outside the web setup wizard; Apple, Android, and Roku have no setup wizard)
On the setup wizard's Subtitles step, a provider's credential fields were unreadable at desktop and tablet widths. With a provider switched on, the "API key" label wrapped onto two lines and the hint "Type to replace the saved value; leave blank to keep it." ran one word per line, about ten lines tall, beside a short input. The OpenSubtitles password input also ran past the card's right edge. Phone widths were fine.
From 40rem up,
.setup-provider-fieldswas a two-column grid, and each cell held a full settings row: label and hint on one side, a 240 px input on the other. Half the card left the label column about 47 px wide.Approach
Remove the two-column rule so the credential fields stack one per line at every width. The admin Providers page lays out the same
SettingFieldandSecretFieldrows this way. Subtitles is the only wizard step that uses these fields inside a grid, so nothing else changes.Validation
Evidence: https://evidence.siloserver.org/r/silo-server/wizard-subtitles-field-layout/
Risks
None identified. The change is CSS only and affects one step of the setup wizard.
Checklist
Council review
Rounds: 1, reviewing 247e8bf
Visual review: 1 round, captures from 247e8bf
Answered: the orphaned last word in the two-line English hint at 1440 px comes from the unit slot every settings row reserves; the tablet heading sitting lower comes from the wizard centering a now-shorter page; the uneven gap above "Test connection" was already there at phone width. The input border contrast (1.37:1 against the card) is the shared settings input style and predates this change.
AI Disclosure
🤖 Generated with Claude Code