Skip to content

fix(web): keep the setup wizard's subtitle credential labels readable at desktop and tablet widths - #4759

Merged
Quick104 merged 1 commit into
mainfrom
fix/wizard-subtitles-secret-field-layout
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/wizard-subtitles-secret-field-layout

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (no client-visible change outside the web setup wizard; Apple, Android, and Roku have no setup wizard)

On the setup wizard's Subtitles step, a provider's credential fields were unreadable at desktop and tablet widths. With a provider switched on, the "API key" label wrapped onto two lines and the hint "Type to replace the saved value; leave blank to keep it." ran one word per line, about ten lines tall, beside a short input. The OpenSubtitles password input also ran past the card's right edge. Phone widths were fine.

From 40rem up, .setup-provider-fields was a two-column grid, and each cell held a full settings row: label and hint on one side, a 240 px input on the other. Half the card left the label column about 47 px wide.

Approach

Remove the two-column rule so the credential fields stack one per line at every width. The admin Providers page lays out the same SettingField and SecretField rows this way. Subtitles is the only wizard step that uses these fields inside a grid, so nothing else changes.

Validation

  • Before and after on the real wizard page, served by Vite from this branch against a mock API built from the repository's contract fixtures, with OpenSubtitles and SubDL on and credentials saved. A dev sandbox couldn't be created during this run. The squeeze was also seen on a dev sandbox built from main while reviewing fix(web): stop the setup wizard re-sending a subtitle provider edit after a failed save #4739.
  • Measured the API key row. Before, at 1440, 820, and 660 px: label column 47 px, label on two lines, hint 190 px tall. After: label on one line, hint on one or two lines. 390 px is unchanged. At 840 px, the narrowest panel once the sidebar appears, the label column grows from 47 px to 110 px and the hint drops from nine lines to four.
  • Checked German (longer text) and Arabic (right to left) at desktop and tablet widths.
  • Setup wizard tests, web lint, Prettier, production build, and the bundle budget check pass.

Evidence: https://evidence.siloserver.org/r/silo-server/wizard-subtitles-field-layout/

Risks

None identified. The change is CSS only and affects one step of the setup wizard.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Rounds: 1, reviewing 247e8bf

Member Round 1
Sol (gpt-6.2-sol, xhigh) 9/10, no findings
Opus (claude-opus-5-5, high) 9/10, no findings
Gemini (gemini-4-neon, xhigh) unavailable (provider quota; the retry failed too)

Visual review: 1 round, captures from 247e8bf

Member Round 1
Sol better, 8/10
Opus better, 8/10
Gemini unavailable (provider quota; the retry failed too)

Answered: the orphaned last word in the two-line English hint at 1440 px comes from the unit slot every settings row reserves; the tablet heading sitting lower comes from the wizard centering a now-shorter page; the uneven gap above "Test connection" was already there at phone width. The input border contrast (1.37:1 against the card) is the shared settings input style and predates this change.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code, Codex, Antigravity (cross-provider review), Playwright (captures)
  • Model(s): claude-opus-5-5 (implementation and code review), claude-sonnet-5-5 (code review conventions and validation checks), gpt-6.2-sol and gemini-4-neon (council review)
  • Involvement: Fully AI-generated. The agent verified it in a browser against a mock API; a person has not verified it yet.
  • Adversarial review: code review at high effort (three finders and a validation check) found no defects in the change; the plan round was skipped because the fix is a mechanical CSS deletion at the root cause. See Council review for the visual and background rounds.

🤖 Generated with Claude Code

…r labels stay readable

From 40rem up, the Subtitles step put a provider's credential fields two
per line. Each field is a full settings row with its label and hint beside
a fixed-width input, so the label column shrank to about 50 px: "API key"
wrapped onto two lines, the keep-or-replace hint ran one word per line,
and the OpenSubtitles password input ran past the card's edge.

Stack the fields one per line at every width, as the admin Providers page
already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aa5e8dd3-4c1c-4485-951d-0412718a2487
Commits

Reviewing files that changed from the base of the PR and between 98d5f0b and 247e8bf.

Files selected for processing: 1

  • web/src/styles/setup-wizard.css
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T01:55:31.489902Z 247e8bf PR opened
🔒 Security Review ✅ Completed 2026-11-21T01:56:36.603007Z 247e8bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌
⚠️ 4 Kody Rule(s) were not evaluated

These rules declare that they need repository context beyond this diff, and the review could not retrieve it, so they were not judged on this pull request:

  • Preserve optional store capabilities through production wrappers
  • Detach mandatory cleanup from request cancellation and bound its lifetime
  • Preserve durable media identity and share identity-evidence precedence
  • Bound decoder throughput trades and share direct-play eligibility

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit 3282395 into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/wizard-subtitles-secret-field-layout branch November 21, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant