Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions web/src/pages/setup-wizard/steps/SubtitlesStep.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
import { render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { beforeEach, describe, expect, it, vi } from "vitest";

import { SubtitlesStep } from "./SubtitlesStep";

const wizardMock = vi.fn();
vi.mock("../WizardContext", () => ({ useWizardContext: () => wizardMock() }));

const updateMock = vi.fn();
// Keep `data` the same object across renders, as React Query does. A new one
// re-runs the step's load effect, whose cleanup cancels an editor read still
// in flight and leaves the row loading.
const providersQuery = {
data: {
providers: [
{ provider_name: "subdl", enabled: false, has_api_key: false, has_credentials: false },
],
},
isLoading: false,
isError: false,
scope: "scope",
refetch: vi.fn(),
};
vi.mock("@/hooks/queries/admin/subtitles", () => ({
useSubtitleProviders: () => providersQuery,
useUpdateSubtitleProvider: () => ({ mutateAsync: updateMock }),
useTestSubtitleProvider: () => ({ mutate: vi.fn(), isPending: false }),
}));

vi.mock("@/api/v2/adminSubtitleProviderConfiguration", () => ({
captureProviderEditIntent: (provider: string) => ({ provider }),
providerIntentActive: () => true,
getProviderEditor: (intent: { provider: string }) =>
Promise.resolve({
intent,
etag: '"1"',
body: {
provider_name: intent.provider,
enabled: false,
has_api_key: false,
has_credentials: false,
},
}),
}));

class ResizeObserverStub {
observe() {}
unobserve() {}
disconnect() {}
}
globalThis.ResizeObserver ??= ResizeObserverStub as unknown as typeof ResizeObserver;

describe("SubtitlesStep", () => {
beforeEach(() => {
vi.clearAllMocks();
wizardMock.mockReturnValue({ markDone: vi.fn(), setSummary: vi.fn() });
updateMock.mockResolvedValue({ saved_revision: "2", local_apply: "not_configured" });
});

it("leaves out credentials typed for a provider that was switched off again", async () => {
const user = userEvent.setup();
render(<SubtitlesStep />);

const toggle = screen.getByRole("switch", { name: "Enable SubDL" });
await waitFor(() => expect(toggle).toBeEnabled());
await user.click(toggle);
await user.type(screen.getByLabelText("API key"), "typed-key");
await user.click(toggle);
expect(screen.queryByLabelText("API key")).not.toBeInTheDocument();

await user.click(screen.getByRole("button", { name: "Continue" }));

await waitFor(() => expect(updateMock).toHaveBeenCalledTimes(1));
expect(updateMock.mock.calls[0]![0].config).toStrictEqual({ enabled: false });
});
});
3 changes: 3 additions & 0 deletions web/src/pages/setup-wizard/steps/SubtitlesStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ function draftFor(config: SubtitleProviderConfig): ProviderDraft {
}

function providerBody(name: string, draft: ProviderDraft) {
// Credentials show only while the provider is on, so one switched off sends
// none and the server keeps whatever it already stores.
if (!draft.enabled) return { enabled: false };
return name === "opensubtitles"
? { enabled: draft.enabled, username: draft.username, password: draft.password }
: { enabled: draft.enabled, api_key: draft.apiKey };
Expand Down
Loading