Repository navigation
Conversation
Section rows read a structured media_scope through ParseConfigFilters, which kept only movie, series, and audiobook. An ebook or manga scope became no type filter, so the default Recently Added, Recently Released, and Random rows for those kinds could show titles of any type in their scope while their See All page showed only the scoped type. Carry ebook and manga as the row's type filter. The section config check now limits only the legacy filter_type key, so rows saved with these scopes keep passing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A
Validation tasks: not checked (the board query was unavailable to the author's token); ebook and manga rows are beta and outside the 1.0 board, and movie, series, audiobook, and video rows behave as before
Other clients: N/A (no client change; every client shows the rows the server returns)
A section row whose config sets
media_scopetoebookormangaapplied no type filter. Its See All page did filter by type. The affected rows include the default Recently Added, Recently Released, and Random rows on ebook and manga library pages. When the row's scope holds other kinds of titles, the row can show titles of other types, while See All shows only the scoped type. A row placed on another library page or on Home through the API shows the same mismatch.This was found while reviewing #4506 and predates it.
Approach
sections.ParseConfigFiltersturned a structuredmedia_scopeinto the row's type filter only formovie,series, andaudiobook. It now does the same forebookandmanga, the type filter See All already applies throughparseCatalogSectionFilters. Every row fetcher that readsParseConfigFiltersgets the filter: Recently Added, Recently Released, Random, and the personal-list rows.The section save check used the same parser to limit the legacy
filter_typekey to movie, series, or audiobook. Once the parser started returningebookandmangafrommedia_scope, that check would have rejected saving the default ebook and manga rows. The check now reads the rawfilter_typekey. The accepted values are unchanged, andmedia_scopeis still validated when the query definition parses.The
videoscope covers two item types and stays out of this change. Recently Added already filters it separately, and no default Recently Released or Random row uses it.Validation
go test ./internal/sections/... ./internal/api/handlers/passes, andmake lint-changedreports no issues.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/pr-4520/
Surface and build: section row queries at commit edb4742 (on main e78f889), tested against a migrated local Postgres.
Follow-ups
video(Recently Released, Random, personal lists) orepisodestill differ from their See All page. Both are reachable only through the API. Tracked in Section rows scoped to video or episode differ from their See All page #4521, together with configs that mix an empty legacy key andmedia_scope, which the row and See All parsers read differently on main.Risks
Ebook and manga rows that showed other types will now show fewer titles. That only happens when a row's scope holds other types, which is the bug. Rows with no scope or another scope are unchanged.
Checklist
AI Disclosure
filter_type, so a stored"Movie"that main accepts would have been rejected. Fixed, and the unit test covers it. It also found that rows scoped tovideoorepisodestill differ from See All on main; that is left out of this PR and tracked as a follow-up. The plan round was skipped because the fix is a few lines at the root cause and adds nothing. A background adversarial review (gpt-6.2-sol, reviewed edb4742) found one case: a config with an empty legacyfilter_typebesidemedia_scopenow filters the row but not See All. The same split already exists on main for the movie, series, and audiobook scopes, so it was added to Section rows scoped to video or episode differ from their See All page #4521 with the shared-parser fix rather than patched here.🤖 Generated with Claude Code