Repository navigation
fix(plugins): reuse saved secrets in connection tests only with the saved settings #3923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Quick104
merged 13 commits into
Silo-Server:main
from
blurbery:fix/plugin-test-secret-destination
Nov 14, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0ef903e
fix(plugins): reuse saved secrets in staged tests only with saved set…
blurbery c76803c
fix(plugins): compare whole secret objects before reusing their secrets
blurbery 68bd543
fix(plugins): treat typed secrets and removed defaults as changed set…
blurbery 2a61a46
fix(plugins): let clear_secrets win in changed connection tests
blurbery 7ddba90
docs(apiv2): say a changed test entry leaves out undeclared stored fi…
blurbery 15932b8
docs(admin-api): limit the staged-test guarantee to the changed entry
blurbery 08d03dc
docs(apiv2): explain how a submitted secret object counts as entered
blurbery a040a64
Merge remote-tracking branch 'origin/main' into pr-3923
Quick104 7a323ad
fix(plugins): count a submitted secret object as entered in connectio…
Quick104 9293b0a
docs(apiv2): say a changed test drops only top-level undeclared fields
Quick104 a935c17
docs(admin-api): note that entries without a declared secret merge as…
Quick104 576135b
Merge remote-tracking branch 'origin/main' into pr-3923
Quick104 87895a2
chore(apiv2): drop the merged updateDownloadSubscription approvals
Quick104 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,3 @@ | ||
| { | ||
| "approvals": [ | ||
| { | ||
| "operation_id": "updateDownloadSubscription", | ||
| "change_id": "request-property-became-not-nullable", | ||
| "fingerprint": "758bc212b081efa8d4532211cf311e027e493fb36971a7b6c9dcf912f025a11e", | ||
| "reason": "The handler already refuses null on every monitor patch field and docs/downloads-api.md says null is rejected; only the document claimed it was accepted. silo-apple omits nil fields, and silo-android and web do not call this operation.", | ||
| "approved_in": "#3535" | ||
| }, | ||
| { | ||
| "operation_id": "updateDownloadSubscription", | ||
| "change_id": "request-property-became-not-nullable", | ||
| "fingerprint": "a3a523da084f36d085bff481d94cebadd34aef3beb97b83d36fd24f79e813acc", | ||
| "reason": "The handler already refuses null on every monitor patch field and docs/downloads-api.md says null is rejected; only the document claimed it was accepted. silo-apple omits nil fields, and silo-android and web do not call this operation.", | ||
| "approved_in": "#3535" | ||
| }, | ||
| { | ||
| "operation_id": "updateDownloadSubscription", | ||
| "change_id": "request-property-became-not-nullable", | ||
| "fingerprint": "d2fbcd692e1d26043b7f191350163753c9df6e86b9007a46204dbad0dd024922", | ||
| "reason": "The handler already refuses null on every monitor patch field and docs/downloads-api.md says null is rejected; only the document claimed it was accepted. silo-apple omits nil fields, and silo-android and web do not call this operation.", | ||
| "approved_in": "#3535" | ||
| }, | ||
| { | ||
| "operation_id": "updateDownloadSubscription", | ||
| "change_id": "request-property-became-not-nullable", | ||
| "fingerprint": "6ab3919a77cf889c326d06ea05fbc49ce68490490a6cd850466928e6cb136c0e", | ||
| "reason": "The handler already refuses null on every monitor patch field and docs/downloads-api.md says null is rejected; only the document claimed it was accepted. silo-apple omits nil fields, and silo-android and web do not call this operation.", | ||
| "approved_in": "#3535" | ||
| }, | ||
| { | ||
| "operation_id": "updateDownloadSubscription", | ||
| "change_id": "request-property-became-not-nullable", | ||
| "fingerprint": "db3bc0b9bc885edf79e8d775113459c401e27e0999625f46c949fbaf1f097240", | ||
| "reason": "The handler already refuses null on every monitor patch field and docs/downloads-api.md says null is rejected; only the document claimed it was accepted. silo-apple omits nil fields, and silo-android and web do not call this operation.", | ||
| "approved_in": "#3535" | ||
| }, | ||
| { | ||
| "operation_id": "updateDownloadSubscription", | ||
| "change_id": "request-property-became-not-nullable", | ||
| "fingerprint": "ac753659fe85643f58ede9067603f9a00b4af6c911480a374c7471eb54b7f7a8", | ||
| "reason": "The handler already refuses null on every monitor patch field and docs/downloads-api.md says null is rejected; only the document claimed it was accepted. silo-apple omits nil fields, and silo-android and web do not call this operation.", | ||
| "approved_in": "#3535" | ||
| } | ||
| ] | ||
| "approvals": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.