Repository navigation
Description
What happened
Taking back a Redis URL replacement can leave the database number staged on its own, so the page keeps an unsaved change nobody made. Typing a new Connection URL also stages the Database number on screen, so the save keeps the number in use. If the settings refresh while the replacement is typed and report a different number (another admin changed it), erasing the replacement takes the URL back but keeps the old number staged. The page then shows one unsaved change, and saving it sends the old number against the settings revision the edit began on, which the server refuses with a conflict.
Steps to reproduce
From the source and a component test in review, not reproduced live:
- Admin › Server › General with a Redis URL saved and database number 2 (or the setup wizard's Storage step).
- Type a new Connection URL. The database number 2 is staged with it.
- Before saving, let the settings refresh report database number 3, for example after another admin saves it.
- Erase the Connection URL. The URL edit is taken back, but
redis.dbstays staged as 2: the save bar still shows one unsaved change, and in the wizard the Redis backend can't be hidden. - Save or Continue: the request is refused with a 412 conflict.
Expected behavior
Taking back a URL replacement also takes back the database number that was staged only to go with it, whatever the snapshot now reports. A number the admin edited stays staged.
Silo version / commit
main at 182a62d
Deployment
Local dev build
Area
Admin pages and settings
Clients affected
Web UI
Relevant logs
No logs available.
Technical notes
keepSavedRedisUrl in web/src/pages/admin-settings/redisDraft.ts resets redis.db only when its draft still equals getPersistedValue("redis.db"), so it can't tell a number staged by stageRedisUrl from one the admin typed once the snapshot moves. Tracking whether the number was staged by the URL edit would fix it. The callers (RedisGroup.tsx and the setup wizard's StorageStep.tsx) are changed by #4816; start after it merges.
Defect: Silo-Server/silo-server web/src/pages/admin-settings/redisDraft.ts keepSavedRedisUrl
AI harness
Claude Code in T3 Code
AI tool(s)
Claude Code; Codex CLI (review)
AI model(s)
claude-opus-5-5; gpt-6.2-sol
AI involvement
Fully AI-generated, human verified
Independent or adversarial review
Found by the adversarial review of #4816 (a component test showed the staged number and the 412), and checked against the source on main.
Confirmations
- I searched open and recently closed issues and pull requests, and this is not already reported
- I reproduced this myself on a real deployment
- Any logs provided are raw apart from marked redactions and are not AI-summarized; if none were available, I said so above
Activity