Skip to content

[bug] Emptying some settings fields stages a value the field doesn't show #4698

Open

Description

@Quick104

What happened

Erasing text typed into a secret field leaves an empty value staged, because the settings snapshot never carries secrets, so the form can't tell the field is back where it started. With no secret saved, Admin > Server > Storage keeps "1 unsaved change" and an empty row that only Discard clears. In the setup wizard, whose secret fields are plain password inputs, erasing a replacement typed over a saved secret stages a clear that Continue sends, and the server accepts it where the secret is optional (for example the Cloudflare token secret after switching back to Signed links).

The Cloudflare token's Token query parameter and Link lifetime fields show their defaults (verify, 10800) when emptied, while the empty value is what's staged. Save then sends the empty value and the server rejects the whole batch (the lifetime must be a positive integer), even after switching back to Signed links.

The wizard's Storage step also has a Hide button on each storage backend that folds edited fields out of view while Continue still saves them.

Steps to reproduce

Admin > Server > Storage, no token secret saved (reproduced on a Silo dev deployment):

  1. Set How asset links are authorized to Cloudflare signed token and open Advanced.
  2. Type into Token Secret, then erase it.
  3. Switch back to Signed links. The save bar still shows "1 unsaved change", and the empty Token Secret row stays (with fix(web): stop settings pages from saving changes the admin can't see #4696; on main the row is hidden and the draft still staged).

Admin > Server > Storage, Cloudflare token defaults (from the source and a component test in review, not reproduced live): with Cloudflare signed token selected, clear Link lifetime. The field still shows 10800; Save sends an empty s3.public_token_ttl and is rejected.

Setup wizard, Storage step (from the source, not reproduced live): with a token secret saved, choose Cloudflare signed token, type into Token secret, erase it, switch back to Signed links, and Continue. s3.public_token_secret is saved as empty, deleting the saved secret.

Expected behavior

A field shows the value that will be saved: an emptied token parameter or lifetime shows empty (or goes back to the saved value), not a default that won't be sent. Emptying a secret field you typed into goes back to the saved state (as SecretField already does for a configured secret on admin pages), and only an explicit clear action stages a clear. Folding a backend in the wizard either keeps its edited fields reachable or leaves them unsaved.

Silo version / commit

main at 28dd148

Deployment

Local dev build

Area

Admin pages and settings

Clients affected

Web UI

Relevant logs

No logs available.

Technical notes

useSettingsForm.setValue reverts a draft only when the snapshot has the key, and secret keys are never in it. SecretField handles emptying with onKeep only when configured is true. The wizard's S3Fields uses SettingField type="password" with form.setValue, so erasing stages "". The wizard's Backend component renders its fields only while open. This touches web/src/pages/setup-wizard/steps/StorageStep.tsx, which #4696 changes; start after it merges.

AI harness

Claude Code in T3 Code

AI tool(s)

Claude Code

AI model(s)

claude-opus-5-5

AI involvement

Fully AI-generated, human verified

Independent or adversarial review

Found by the code review and visual review of #4696 and checked against the source; the admin case reproduced on a dev deployment.

Confirmations

  • I searched open and recently closed issues and pull requests, and this is not already reported
  • I reproduced this myself on a real deployment
  • Any logs provided are raw apart from marked redactions and are not AI-summarized; if none were available, I said so above

Source: found in review of #4696. Follows #4696.

Activity

  1. added
    priority: P2Limited scope, workaround exists, or polish
    triagedHigh-confidence review completed; does not mean fixed, validated, or accepted for release.
    on Nov 20, 2026
  2. changed the title [-][bug] Erasing typed secret text stages an empty value, and the wizard can clear a saved secret[/-] [+][bug] Emptying some settings fields stages a value the field doesn't show[/+] on Nov 20, 2026
  3. self-assigned this
    on Nov 21, 2026
  4. Quick104 commented on Nov 21, 2026

    @Quick104
    ContributorAuthor

    🤖 AI agent claim. Claude Code in T3 Code (claude-opus-5-5) is working on a fix for this issue on behalf of @Quick104, who is assigned.

    A pull request will link here when the fix is ready. If the work stops without a fix, the assignment and this comment are removed.

    Planning to work on this, or have context to add? Reply here and mention @Quick104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority: P2Limited scope, workaround exists, or polishtriagedHigh-confidence review completed; does not mean fixed, validated, or accepted for release.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions