Skip to content

[bug] AI settings, the setup wizard's Features step, and Playback markers save changes the admin can't see #4697

Open

Description

@Quick104

What happened

On AI settings, the setup wizard's Features step, and the marker settings on Playback, a field hidden by another setting keeps its unsaved edit. The save bar (or the wizard's Continue) counts and saves a value the admin can no longer see. #4696 fixes the same problem on the Compatibility, Storage, and Playback transcoding pages and on the wizard's Storage and Connect apps steps. These are left out of it because open PR #4668 edits the neighboring lines in AI settings and the Features step, and the marker settings share an automatic markers.lazy_playback write with the Features step that needs one decision for both.

Steps to reproduce

Setup wizard, Features step (reproduced on a Silo dev deployment):

  1. Turn Downloads on and set Total download bandwidth to 50.
  2. Turn Downloads off. The bandwidth field disappears.
  3. Continue. download.server_bandwidth_mbps is saved as 50.

Admin > Playback > Settings, markers (reproduced on a Silo dev deployment, saved marker source "Detect on this server"):

  1. Set Marker source to "Online preferred + server detection".
  2. Set Save online markers to "Fetch when needed". This also stages markers.lazy_playback=true.
  3. Set Marker source back to "Detect on this server". The online storage field disappears, and the save bar still counts 2 changes.

The same gates, from the source (not reproduced live):

  • AI settings: Service tier (ai.service_tier) shows only for an OpenAI provider. Pick a tier, then switch to another provider or to the ChatGPT plan: the tier is hidden and still saved.
  • AI settings: choosing the ChatGPT plan after picking a different API-key provider leaves ai.text_provider_id staged with no control showing it.
  • Features step: Save online markers while online markers are off, the recommendations provider and model while recommendations are off, and the markers.lazy_playback and push switches that setOnlineMarkers, setLocalMarkers, and setPush stage alongside the visible switch.
  • Playback markers: the intro and credits detection switches and the detection worker count, hidden by Marker source; markers.lazy_playback, hidden for on-demand online markers.

Expected behavior

Save never writes a value the admin can't see. A field that holds an unsaved edit stays on screen, marked with the unsaved-change dot, or the edit is taken back with the change that hid it, as #4696 does on the other pages. The automatic markers.lazy_playback=true staged with on-demand online markers needs one rule for Playback and the Features step.

Silo version / commit

main at 28dd148

Deployment

Local dev build

Area

Admin pages and settings

Clients affected

Web UI

Relevant logs

No logs available; the values were read back from the settings table after Continue.

Technical notes

The pages render these fields behind conditions on other form values, while useSettingsForm keeps every dirty key and save() writes them all. #4696 applies gate || isDirty(key) per row and marks kept rows with dirty. Start this after #4668 merges.

AI harness

Claude Code in T3 Code

AI tool(s)

Claude Code

AI model(s)

claude-opus-5-5

AI involvement

Fully AI-generated, human verified

Independent or adversarial review

Found during review of #4696: an Explore sweep of every settings page, then checked against the source line by line; the Features and marker cases reproduced on a dev deployment.

Confirmations

  • I searched open and recently closed issues and pull requests, and this is not already reported
  • I reproduced this myself on a real deployment
  • Any logs provided are raw apart from marked redactions and are not AI-summarized; if none were available, I said so above

Source: found in review of #4696. Follows #4668.

Activity

  1. added
    priority: P2Limited scope, workaround exists, or polish
    triagedHigh-confidence review completed; does not mean fixed, validated, or accepted for release.
    on Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority: P2Limited scope, workaround exists, or polishtriagedHigh-confidence review completed; does not mean fixed, validated, or accepted for release.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions