Skip to content

Honor the plugin manifest's stay_running field in idle stops #3974

Open

Description

@Quick104

Problem

#3960 stops a non-resident plugin process after 30 minutes without use. A plugin whose manifest sets the new stay_running field (Silo-Server/silo-plugin-sdk#65) must not be stopped for being idle.

Proposal

  • Bump the SDK to the release that adds PluginManifest.stay_running.
  • In internal/plugins/service.go, start with StopWhenIdle: !isResidentManifest(manifest) && !manifest.GetStayRunning().
  • Update docs/architecture/plugin-idle-stop.md ("What is never stopped") and the admin API doc's note on non-resident plugins.
  • Add a test that a plugin whose manifest sets stay_running is started without StopWhenIdle.

Depends on #3960 and Silo-Server/silo-plugin-sdk#65.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpriority: P2Limited scope, workaround exists, or polish

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions