Repository navigation
Conversation
A request names seasons by TMDB's numbering. Download services such as Sonarr split or merge some series differently, so a plugin matching by number monitors the wrong episodes. RequestDescriptor.season_details carries each requested season's first air date and episode count, so a plugin can match the same episodes by air date.
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
| // plugin matches by air date rather than by number: the season is the first | ||
| // episode_count regular episodes, in airing order, that air on or after | ||
| // first_air_date. |
There was a problem hiding this comment.
Air-date matching selects regular episodes for Specials requests
A request for season 0 with a date and count can acquire unrelated episodes and omit the requested Specials. Specify a separate matching rule for Specials, such as matching season 0 by number.
Prompt for LLM
File proto/silo/plugin/v1/request_router.proto, lines 52-54:
Air-date matching selects regular episodes for Specials requests
A request for season 0 with a date and count will match regular episodes instead of the requested Specials, so a conforming plugin can acquire unrelated episodes and omit the requested ones. Specify a separate matching rule for Specials, such as matching season 0 by number.
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
There was a problem hiding this comment.
Fixed in 90dbbd7: the RequestedSeason comment and docs/compatibility.md now say Specials (season 0) are always matched by number and a host need not describe them. Silo's server never sends season 0 details (it drops season 0 from season requests), and the Sonarr plugin already matches season 0 by number.
There was a problem hiding this comment.
Thanks for clarifying. Matching season 0 by number addresses the issue I raised, and the server and Sonarr behavior you describe is consistent with that rule. I haven’t independently verified commit 90dbbd7.
A Specials season is not regular episodes, so air-date matching would pick the wrong ones. Say that plugins match season 0 by number.
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Brings in v0.33.0 so the release that carries season_details contains it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Quick104
left a comment
There was a problem hiding this comment.
🤖 Claude Code (claude-opus-5-5)
I merged main into this branch (f6d86d2), so the release that carries season_details also contains v0.33.0. make proto leaves the merged head unchanged, and go vet ./... and go test ./... pass.
Three documentation findings on the contract are below. I'm fixing all three in a commit on this branch, so there's no need to change anything yourself.
State in the RequestedSeason contract what silo-server and the Sonarr plugin already do: a count of 0, or details that match no episode, fall back to the season number, and a partial match uses the episodes found. Tell plugins to find a detail by number, since the list can leave seasons out, and date the field to v0.34.0, as v0.33.0 shipped without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
|
🤖 Claude Code (claude-opus-5-5) Review summaryReviewed head: b635842 (the contributor's commits, a merge of Addressed
Each fix is in b635842. Checked and fine
Left for the maintainers
Validation
VerdictFit: 8/10 · Readiness: 8/10 — conditional
|
Problem
Related issue: Silo-Server/silo-server discussion #4454
A season request reaches a request router plugin as TMDB's season numbers and nothing else. Download services number some series differently: TMDB files DAN DA DAN as one 24-episode season, while Sonarr has two seasons of 12. A plugin that matches by number monitors Sonarr's season 1 and gets half of what the user asked for. The plugin has no way to tell which episodes the host meant.
This adds each requested season's first air date and episode count to the request, so a plugin can find the same episodes in its own service by air date.
Approach
RequestDescriptorgetsrepeated RequestedSeason season_details = 11, one entry per season inseasons, in the same order.RequestedSeasoncarries the seasonnumber,first_air_date(YYYY-MM-DD, empty when TMDB has none yet) andepisode_count(0 when unknown). The proto comment describes the matching rule: the season is the firstepisode_countregular episodes, in airing order, airing on or afterfirst_air_date, or the ones that match when fewer do. A plugin finds each detail bynumber, since the list can leave seasons out. It matches a season by number when it has no detail, when the detail has no date or a count of 0, when no episode matches, and always for Specials.The change is additive and first ships in v0.34.0; the branch contains v0.33.0. A host that predates the field, a whole-series request, and a request stored before the host kept the details all send an empty list, and a plugin then matches by number as before.
docs/compatibility.mdrecords that presence rule and the README section on season requests describes the field for plugin authors.The server side (storing the details with each request and sending them) and the Sonarr plugin side are separate pull requests that need this one merged and released first; they link back here.
Validation
go test ./...,go vet ./..., the four example builds: pass.make proto: regenerating leaves the committed generated code unchanged.gofmt -l .: onlypkg/pluginsdk/runtime/scan_source_test.go, which this change does not touch and which already differs onmain.season_detailsarrives, and that a request with only season numbers still delivers them with no details.Evidence
No user-visible change. The wire test above covers the contract. The server and Sonarr plugin pull requests built on this field were run end to end against a real Sonarr 4.0.20; results are in those pull requests.
Risks
None identified. The field is new and optional; existing plugins ignore it.
Checklist
AI Disclosure
Note
Add
season_detailsfield toRequestDescriptorfor request routersRequestedSeasonmessage and a repeatedseason_detailsfield (number 11) toRequestDescriptorin request_router.proto, carrying season number, first air date, and episode countMacroscope summarized b635842.