Skip to content

build: list FreeBSD in the network access example manifest - #71

Merged
Quick104 merged 1 commit into
mainfrom
build/freebsd-binaries
Nov 17, 2026
Merged

Quick104 merged 1 commit into
mainfrom
build/freebsd-binaries

Conversation

@Quick104

@Quick104 Quick104 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A — narrow fix

The shared plugin-release workflow will build freebsd/amd64 and freebsd/arm64 by default (Silo-Server/.github#5). The SDK's only sample supported_platforms list, in examples/hello-network-access/manifest.json, still names Linux and macOS only, so a plugin author who copies it would leave FreeBSD out of the manifest while the release ships FreeBSD binaries.

Approach

Add freebsd/amd64 and freebsd/arm64 to that example manifest, so it matches the workflow's default list. Nothing else in the SDK needs to change for FreeBSD: no validator restricts os or arch (SupportedPlatform is two free strings in proto/silo/plugin/v1/common.proto, and pkg/pluginsdk/manifest does not check them), and the other examples declare the platform they were built on (runtime.GOOS/GOARCH). The docs describe building for the server's platform without naming a standard set.

No contract, API, or generated code changes. No SDK release is needed for plugins to ship FreeBSD.

The FreeBSD binaries are cross-compiled with CGO_ENABLED=0; the project does not run them on FreeBSD.

Validation

Go 1.26.5:

  • go test ./...: all packages pass.
  • go vet ./...: clean.
  • go build of the four examples: ok.
  • CGO_ENABLED=0 GOOS=freebsd GOARCH=amd64 and GOARCH=arm64: go build of all four examples and go vet ./... pass.
  • ./hello-network-access manifest prints the five platforms from the embedded manifest.
  • gofmt -l . prints pkg/pluginsdk/runtime/scan_source_test.go, which is unformatted on main and not touched here.

Evidence: https://evidence.siloserver.org/r/silo-plugin-sdk/pr-71/

Risks

None identified. The change is an example manifest.

AI Disclosure

  • Harness: Claude Code (in T3 Code)
  • Tool(s): Claude Code
  • Model(s): claude-opus-5-5
  • Involvement: Fully AI-generated, human verification pending
  • Adversarial review: n/a (example manifest only)

🤖 Generated with Claude Code

Note

Add FreeBSD amd64 and arm64 targets to network access example manifest

Adds freebsd/amd64 and freebsd/arm64 target entries to manifest.json in the hello-network-access example, so the manifest now lists FreeBSD alongside the existing platforms.

Macroscope summarized 9ae3465.

The example manifest is the SDK's one sample supported_platforms list.
It now matches the shared plugin-release workflow's default platforms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 17, 2026
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The hello-network-access manifest adds FreeBSD support for the amd64 and arm64 platforms.

Changes: FreeBSD Platform Support

Layer / File(s) Summary
Add FreeBSD platforms
examples/hello-network-access/manifest.json
The manifest adds freebsd/amd64 and freebsd/arm64 to supported_platforms.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 9ae34

This change lists FreeBSD on amd64 and arm64 in the hello-network-access example manifest. It only affects sample metadata and carries no meaningful merge risk.

Architecture risk: Low · up to 9ae34

The change affects 1 system.

Changed systems: examples

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — examples (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in examples/hello-network-access/manifest.json: Adds freebsd/amd64 and freebsd/arm64 entries to supported_platforms.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "build: list FreeBSD in the network access example manifest" matches the changeset, which adds freebsd/amd64 and freebsd/arm64 to examples/hello-network-access/manifest.json. It is specific …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that the PR adds freebsd/amd64 and freebsd/arm64 to the hello-network-access example manifest so it matches the shared plugin-release workflow's default platforms. It also gives…
Full details: Title check

Explanation

The title "build: list FreeBSD in the network access example manifest" matches the changeset, which adds freebsd/amd64 and freebsd/arm64 to examples/hello-network-access/manifest.json. It is specific and names the file's purpose.

Full details: Description check

Explanation

The description states that the PR adds freebsd/amd64 and freebsd/arm64 to the hello-network-access example manifest so it matches the shared plugin-release workflow's default platforms. It also gives the reasoning, the validation steps run, and the CGO_ENABLED=0 cross-build note. This matches the raw summary, which says the manifest gains FreeBSD amd64 and arm64 entries. The description is related to the changeset and is not off-topic.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d7056b2b-274b-4de0-ab8d-e087285b251d
Commits

Reviewing files that changed from the base of the PR and between b82b589 and 9ae3465.

Files selected for processing: 1

  • examples/hello-network-access/manifest.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T14:26:39.883837Z 9ae3465 PR opened
🔒 Security Review ✅ Completed 2026-11-17T14:27:52.659002Z 9ae3465 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added documentation Improvements or additions to documentation triaged High-confidence review completed; does not mean fixed, validated, or accepted for release. labels Nov 17, 2026
@Quick104
Quick104 merged commit 5717267 into main Nov 17, 2026
4 checks passed
@Quick104
Quick104 deleted the build/freebsd-binaries branch November 17, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/S 0–49 added + deleted lines (all files); change volume, not priority. triaged High-confidence review completed; does not mean fixed, validated, or accepted for release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant