Repository navigation
build: list FreeBSD in the network access example manifest - #71
Merged
Merged
Conversation
The example manifest is the SDK's one sample supported_platforms list. It now matches the shared plugin-release workflow's default platforms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A — narrow fix
The shared plugin-release workflow will build
freebsd/amd64andfreebsd/arm64by default (Silo-Server/.github#5). The SDK's only samplesupported_platformslist, inexamples/hello-network-access/manifest.json, still names Linux and macOS only, so a plugin author who copies it would leave FreeBSD out of the manifest while the release ships FreeBSD binaries.Approach
Add
freebsd/amd64andfreebsd/arm64to that example manifest, so it matches the workflow's default list. Nothing else in the SDK needs to change for FreeBSD: no validator restrictsosorarch(SupportedPlatformis two free strings inproto/silo/plugin/v1/common.proto, andpkg/pluginsdk/manifestdoes not check them), and the other examples declare the platform they were built on (runtime.GOOS/GOARCH). The docs describe building for the server's platform without naming a standard set.No contract, API, or generated code changes. No SDK release is needed for plugins to ship FreeBSD.
The FreeBSD binaries are cross-compiled with
CGO_ENABLED=0; the project does not run them on FreeBSD.Validation
Go 1.26.5:
go test ./...: all packages pass.go vet ./...: clean.go buildof the four examples: ok.CGO_ENABLED=0 GOOS=freebsd GOARCH=amd64andGOARCH=arm64:go buildof all four examples andgo vet ./...pass../hello-network-access manifestprints the five platforms from the embedded manifest.gofmt -l .printspkg/pluginsdk/runtime/scan_source_test.go, which is unformatted onmainand not touched here.Evidence: https://evidence.siloserver.org/r/silo-plugin-sdk/pr-71/
Risks
None identified. The change is an example manifest.
AI Disclosure
🤖 Generated with Claude Code
Note
Add FreeBSD amd64 and arm64 targets to network access example manifest
Adds
freebsd/amd64andfreebsd/arm64target entries to manifest.json in thehello-network-accessexample, so the manifest now lists FreeBSD alongside the existing platforms.Macroscope summarized 9ae3465.