Repository navigation
Conversation
…equester or approver A request router plugin reads every setting of a request from the connection config an admin saved, or a routing rule's. A host had no way to know that one of those settings, such as a quality profile or a root folder, could instead be chosen per request, so the choice could only be made by the admin in advance. RequestRouterDescriptor.requester_options lists the config fields that may be chosen per request. Each names a select with dynamic_options, an optional media type and label, and a chooser_field: a select in the same form in which an admin says per server who chooses (admin, requester or approver). The host offers the values ListConfigOptions returns, checks the pick against them and passes it as that key of RouterConnection.config, so the plugin's RPCs do not change. Manifest validation checks the declaration against the admin form. Hosts that predate the field drop it and never offer the choice. AI disclosure: written with Claude Fable 5.2 in Claude Code. go test ./... and go vet pass locally. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
… scope the compatibility note A requester option's pick is a ConfigOption value, which is a string. A select may sit on a numeric json_schema property, and setting the pick there would change the type the plugin reads. Manifest validation now refuses a requester option whose field is not a string property. The compatibility note said older hosts ignore the field. That holds for loading a manifest, which every SDK version does leniently. It now also names the two stricter paths: Silo's read of a bare binary's manifest, and stored capability metadata on an SDK older than v0.13.1. AI disclosure: written with Claude Fable 5.2 in Claude Code. go vet and go test pass locally; pkg/pluginproto was regenerated with buf. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #67
Related issue: Silo-Community/silo-plugins-requests-seerr#10 (the plugin issue this change comes from; the fix spans this SDK, silo-server and the plugin)
A request router plugin reads every setting of a request from the connection config an admin saved, or from a routing rule. A host cannot tell that one of those settings, such as a quality profile or a root folder, could be chosen per request. Today only the admin can choose, and only in advance. Someone with one download server that serves several uses cannot say which profile or folder a title should get, even though the requester or the approving admin knows
Approach
RequestRouterDescriptor.requester_optionslists the config fields that may be chosen per request. Each entry names:field: a select withdynamic_options, the setting being chosen;chooser_field: a select in the same admin form where the admin says, per server, who chooses (admin,requesterorapprover).The host offers the values
ListConfigOptionsreturns, checks the pick against them and passes it as that key ofRouterConnection.config. The plugin's RPCs do not change.chooser_fieldis a select rather than a boolean so one setting can be left to the admin, the requester or the approver without another field. Manifest validation checks thatfieldis a select withdynamic_optionsand thatchooser_fieldis a static select offering only those three values.Validation
Not run:
buf generate(no diff check) and anything outside this repo. The host side (silo-server) and the first plugin to declare options (silo-plugins-requests-seerr) are separate PRs; links to follow once they are open.Risks
docs/compatibility.md.Checklist
Related PRs:
AI Disclosure
Note
Add requester-option declarations to request-router plugin manifest
RequesterOptionand a repeatedrequester_optionsfield (number 6) onRequestRouterDescriptorin request_router.proto.validateRequesterOptionsin manifest.go checks that each option's field is a dynamic admin-form select with a string JSON-schema type, media types do not overlap for the same field, labels respect the wording label limit, and a chooser field is a static select with only supported values.Macroscope summarized 1fe3386.