Repository navigation
deps: bump tailscale.com to 1.104.7 and Go to 1.27.4 - #9
Merged
Merged
Conversation
govulncheck fails on GO-2026-6865 in klauspost/compress v1.20.0 and GO-2026-6859 in net/http from Go 1.27.3, so this moves compress to v1.20.4, Go to 1.27.4 and Tailscale to its latest stable release, which itself requires Go 1.27.4. The reviewed-toolchain pin in dist.py, its test and the development docs now name go1.27.4, whose LICENSE is identical to go1.26.7's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A (maintainer-directed)
make auditfails onmainand on every pull request because of two advisories published this week:github.com/klauspost/compressv1.20.0 (indirect, throughtailscale.com), fixed in v1.20.2.net/httpin Go 1.27.3, fixed in Go 1.27.4.Tailscale is also behind its latest stable release.
go.mod)tailscale.comgithub.com/klauspost/compressApproach
go get.tailscale.comv1.104.7 requires Go 1.27.4 itself. Its dependency changes moved two more indirect modules:github.com/tailscale/glidersshandgithub.com/tailscale/wireguard-go. Nothing else moved.go mod tidyagainst both the prepared.build/go.modand the root module. Both produce the samego.mod.go.sumcomes from the root tidy because the prepare script needs thetailscale.comchecksum, which the prepared module drops because of itsreplace.go.sumwas not edited by hand.scripts/prepare_tailscale.pyneeded no changes. Neitherfeature/acmenoripn/storechanged upstream between the two versions.tsnet/tsnet.gogained only anSSHAuthCallbackfield, and every exact-match patch still applies.scripts/dist.pyusesscripts/GO_LICENSE.txtas a fallback when the toolchain has noGOROOT/LICENSE(Nix), and accepts it only for one reviewed Go version. I compared theLICENSEfile at thego1.26.7andgo1.27.4tags in golang/go and the 1.27.4 toolchain'sGOROOT/LICENSEwith the bundled file. All four are byte-identical (SHA-256911f8f57…9dad), so I moved the pin, its test, and the version indocs/DEVELOPMENT.mdto go1.27.4. CI reads the version fromgo.mod, so the workflow did not change.This supersedes dependabot's #7, which bumps
tailscale.comonly to v1.104.5 and does not fix either advisory.Validation
Go 1.27.4 ran every command below. The local Go is 1.26.5, and
GOTOOLCHAIN=autoswitched to go1.27.4 from thegodirective.make check: passed (7 Python script tests,go test -racefor both plugin packages, the ACME state-store regression in the adapted Tailscale package,go vet, gofmt).make audit: "No vulnerabilities found" in imported packages. It still lists three advisories in required modules that the plugin's packages do not import: GO-2026-6866 and GO-2026-6860 ingolang.org/x/netv0.61.0, and GO-2026-5932 ingolang.org/x/cryptov0.58.0. These do not fail the audit, and this PR leaves them alone.make dist VERSION=0.2.2: built and verified linux/amd64, linux/arm64, and darwin/arm64 archives. A second build produced identical checksums, matching CI's reproducibility step.tailscale.comv1.104.7, andklauspost/compressv1.20.4.go version -mon the linux/amd64 binary confirms go1.27.4 and the same module versions.plugin manifeston the linux/amd64 binary reports plugin IDironicbadger.network-access.tailscaleand version0.2.2.Risks
From the Tailscale changelog for v1.104.4 to v1.104.7 and the source diff:
TS_NETSTACK_ENABLE_RACK=trueturns it back on). This changes TCP recovery for every connection the plugin proxies, including long playback streams. It should help on lossy links but may be slower on paths that reorder packets.None of this was tested against a live tailnet or a Silo server. The tsnet tests run against Tailscale's local test control server.
Checklist
AI Disclosure
🤖 Generated with Claude Code