Repository navigation
build: publish FreeBSD binaries - #11
Merged
Merged
Conversation
Build, verify, sign, and publish freebsd/amd64 and freebsd/arm64 archives and raw binaries alongside the existing targets. dist.py checks the ELF OS/ABI byte so a FreeBSD archive cannot hold a Linux binary. Raise the version to 0.2.4 in manifest.json and the Makefile so the merge commit is the taggable release commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A — narrow fix
A Silo server running on FreeBSD can't install this plugin. Releases ship Linux and macOS binaries only, and
manifest.jsonlists only those platforms, so the server doesn't offer the plugin onfreebsd/amd64orfreebsd/arm64.Approach
Add both FreeBSD targets everywhere this repository lists release platforms:
manifest.jsonsupported_platforms.scripts/dist.pyPLATFORMS, somake distbuilds, packages, and verifies a ZIP archive for each.verify_binarygains a FreeBSD branch that checks the ELF machine type and the OS/ABI byte (Go writes 9, FreeBSD), so a FreeBSD archive can't carry a Linux binary..github/workflows/release.yml: the loop that extracts the rawplugin-<os>-<arch>binaries and adds them tochecksums.txt, the signing job's expected subject list, and the release's file list. The archives and checksums reach the attestation, bundle verification, and catalog dispatch steps throughchecksums.txt, so those steps need no other change.docs/DEVELOPMENT.md, which lists the archivesdist/contains.versiongoes from 0.2.3 to 0.2.4 inmanifest.jsonand in the MakefileVERSIONdefault, as the release section ofdocs/DEVELOPMENT.mdrequires.No plugin code changes. With the repository's adapted Tailscale source (
make prepare), the plugin and its embeddedtsnetnode compile and vet for both FreeBSD targets withCGO_ENABLED=0.Once 0.2.4 is released and the community catalog picks it up, a FreeBSD server admin sees the plugin in the catalog and can install it, or download the FreeBSD ZIP from the release.
Validation
Toolchain: Go 1.27.4, Python 3 (darwin/arm64 host).
Before editing, on
mainaftermake prepare, with the Makefile'sGOFLAGS:After the change, the CI gate:
filereports thepluginin each FreeBSD archive as a statically linked FreeBSD ELF executable (x86-64 and aarch64), and each archive's manifest lists all five platforms. I also ran the release workflow's "Prepare release assets" loop and the signing job's subject-list comparison by hand against thatdist/: the subject list matches all 10 assets.verify_binaryaccepts both FreeBSD binaries and rejects a Linux binary and a wrong-architecture FreeBSD binary.The FreeBSD binaries are cross-compiled only; nobody on the project ran them on a FreeBSD host. The real-tailnet checks listed under "Validation scope" in
docs/DEVELOPMENT.mdwere not run on FreeBSD.Evidence: https://evidence.siloserver.org/r/silo-plugin-tailscale/freebsd-binaries/
Risks
Existing platforms build as before. On FreeBSD, the plugin's
tsnetnode is untested at runtime: enrollment, certificates, and the listeners have only been compiled for FreeBSD. Releases get two more archives and two more raw binaries.Other clients: N/A (no client-visible change)
Checklist
AI Disclosure
🤖 Generated with Claude Code