🎨 Palette: Global button focus visibility#69
Conversation
Added `focus-visible` states to `.ui-btn-primary` and `.ui-btn-secondary` in `app/globals.css` to ensure consistent keyboard accessibility. Removed redundant explicit classes from `components/ui/footer.tsx` and updated `.Jules/palette.md` with the new learning. Co-authored-by: SillyHippy <159052837+SillyHippy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying bolt-site with
|
| Latest commit: |
a0b3140
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2417d975.bolt-site.pages.dev |
| Branch Preview URL: | https://palette-global-button-focus.bolt-site.pages.dev |
💡 What: Added
focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500 focus-visible:ring-offset-2directly to.ui-btn-primaryand.ui-btn-secondaryglobal utility classes inapp/globals.css. Removed redundant focus classes fromcomponents/ui/footer.tsx.🎯 Why: Previously, buttons using these utility classes lacked keyboard focus visibility unless it was explicitly added per-instance. This caused inconsistent accessibility, with some buttons (like in the navbar) missing focus rings entirely. Baking it into the global utility ensures every button using it is accessible by default.
📸 Before/After: See the attached visual verification screenshot.
♿ Accessibility: Guarantees keyboard navigators will always have a visible focus indicator when tabbing through action buttons using these standard utility classes.
PR created automatically by Jules for task 11376043093237191673 started by @SillyHippy