chore(quality): define TypeScript test contract - #1035
Open
aaf2tbz wants to merge 3 commits into
Open
Conversation
aaf2tbz
marked this pull request as ready for review
July 28, 2026 04:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establish the TypeScript/test-contract slice of #919. This PR makes the maintained test surface explicit and introduces the minimum shared TypeScript strictness improvement; it does not close the issue.
Changes
references/.noUncheckedIndexedAccessin the shared root TypeScript config and fixed the newly surfaced unsafe connector-base indexing.Type
feat— new user-facing feature (bumps minor)fix— bug fixrefactor— restructure without behavior changechore— build, deps, config, docsperf— performance improvementtest— test coveragePackages affected
@signet/core@signet/daemon@signet/cli/ dashboard@signet/sdk@signet/connector-*@signet/webpredictorScreenshots
N/A — developer tooling and test contract only.
PR Readiness (MANDATORY)
INDEX.md+dependencies.yaml)Migration Notes (if applicable)
N/A — no migrations changed.
Testing
bun testpassesbun run typecheckpassesbunx biome checkpasses for changed handwritten filesValidated:
bun test scripts/test-contract.test.ts tests/integration/web-content-index-regression.test.ts libs/connector-base/index.test.tsbun run --filter '@signet/core' buildnpx tsc -p platform/core/tsconfig.json --noEmitnpx tsc -p libs/connector-base/tsconfig.json --noEmit --noUncheckedIndexedAccessgit diff --checkAI disclosure
Follow-ups
The full maintained-suite command deliberately exposes remaining baseline debt: Rust route-parity artifacts and native SQLite-extension coverage. PR 3 owns the Rust baseline; PR 4 makes the now-defined checks mandatory in CI and branch protection. The daemon typecheck remains non-blocking until #969 is resolved.