Fix stray end breaking parse of hybrid_systems.jl#139
Closed
luke-kiernan wants to merge 1 commit into
Closed
Conversation
The ReserveUp `_emit_coverage_constraint!` method had an extra `end` (the `if/else` already closes, then the function closes), which made src/hybrid_system_models/hybrid_systems.jl fail to parse and broke precompilation of PowerOperationsModels on main. Introduced by the hybrid systems port (#104). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Also addressed in #138 so I guess I'll close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/hybrid_system_models/hybrid_systems.jlcurrently fails to parse onmain, breaking precompilation ofPowerOperationsModels.The ReserveUp
_emit_coverage_constraint!method has an extraend: theif/elsealready closes (line 1618) and the function closes (line 1621), leaving a strayendat line 1619.Introduced by the hybrid systems port (#104, merged via #105). Removing the stray
endmakes the file parse and the package precompile again.🤖 Generated with Claude Code