Conversation
|
Replace Gaia-local unit wrappers with qtty JulianYears, angular rates, and astro::ProperMotion, and align proper-motion propagation with Julian-year catalogue conventions. Use qtty velocity::C for photon-flux integration instead of a local speed-of-light constant.
Replace the Gaia-specific Nanometers newtype with crate::qtty::Nanometers while keeping catalogue validation in a small helper.
Promote the unreleased changelog and align workspace crate versions in Cargo.toml and Cargo.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds first-class Gaia DR3 catalogue support to Siderust, focused on a typed ingestion boundary and starlight-ready photometry primitives.
What changed
catalogs::gaiamodule with a strict raw/domain split:GaiaDr3RawSourceRowfor CSV/ADQL boundary data.GaiaDr3Sourcefor validated domain records.catalogs::gaiaandcatalogs.quick-xmlfrom0.40to0.41.Validation covered by tests
The PR adds unit coverage for:
Scope note
This introduces the typed Gaia DR3 ingestion and photometry foundation needed by starlight products. Network retrieval, large-scale catalogue download orchestration, and production map generation remain separate pipeline/tooling concerns.