chore: bump sync-openapi-version pin to v0.1.0 - #1015
Merged
Merged
Conversation
The previous pin predates SiaFoundation/workflows#27, so the sync step resolved no spec files and never opened a version-bump PR. Labelling the pin v0.1.0 also lets Dependabot track it from here on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The pin matches the verified upstream v0.1.0 tag and preserves the existing workflow configuration.
Pull request overview
Updates the OpenAPI synchronization workflow to the upstream version containing the spec-resolution fix.
Changes:
- Pins
sync-openapi-version.ymltov0.1.0.
File summaries
| File | Description |
|---|---|
.github/workflows/openapi-sync.yml |
Updates the reusable workflow commit pin. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
sync-openapi-version.ymlpin toead28a5, tagged v0.1.0, which includes the fix from SiaFoundation/workflows#27.Why
The previous pin predates that fix, so every run of this workflow resolved zero spec files, logged
No spec files resolved.and exited green without opening a PR. That is why this repo's spec still declares a version well behind the latest release.The pin is labelled
# v0.1.0rather than# master. Dependabot resolves action pins against the target repo's tags and reads that trailing comment for the current version, so labelling it is what lets this pin be tracked automatically from here on.Verified upstream
Already merged and dispatched in s3d#268: the sync step now resolves the spec and reports
Updated openapi.yml: 0.1.1 -> 0.1.4, where the old pin reportedNo spec files resolved.Heads up on the first sync PR
Once this lands, the next release (or a manual
workflow_dispatch) opens a version-bump PR. The workflow writes withyq -i, which reserializes the whole document — it collapses hand-wrapped block scalars onto single lines and strips blank lines between sections. So the first such PR reformats the spec rather than changing one line. It is semantically lossless (parsed documents are byte-identical apart from the version), and it is one-time: afterwards the file is in yq's canonical style and later bumps are clean two-line diffs. This was a deliberate call — the alternative fix was considered and declined in SiaFoundation/workflows#28.Scope
Only the
openapi-sync.ymlpin. Other references to SiaFoundation/workflows in this repo are on their own SHAs and are better bumped separately, with their own testing.🤖 Generated with Claude Code