Wrong 7D Revenue accounting

[serveriukai]

Current Behavior

During 7 days hosted on average 0.82 TB of data at a steady price. Three days ago I decided to not accept contracts anymore.

360 TB/months.
Earned for storage 144.80 mS
No failed or rejected contracts.
Host properly synchronized.

Screenshots attached

... ...

Expected Behavior

Storage revenue, or maybe potential revenue, or some sort of business for that period should be higher than 60 SC.

Steps to Reproduce

No response

Version

v2.3.6, v2.3.5

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Debian12

Anything else?

No response

[serveriukai]

I changed status to "Accepting contracts" = ON
nothing changed. Error is not related to acceptance of contracts.

So I removed this factor from Issue headline.

[timrettop]

I think this may be a similar issue, if not, let me know if I should create a different one.

Revenue graph shows some revenue yesterday during a specific hour window, however there's no matching wallet transactions.

And the transactions in my wallet.

[peterjan]

@n8mgr I think it's highly likely that this accounting bug is caused by the contract statuses issue. When the resolution was dropped because of that switch bug, we don't updateXXMetric so storage revenue would stay stuck in PotentialStorageRevenue and locked + risked collateral is counted twice.

[n8mgr]

It is not. We double count renewal resolution revenue.