Skip to content

stats do not reflect the actual amount in active contracts #788

Description

@npelov

Current Behavior

If I set time to ALL I see potential earnings much lower than it should be. As you see the risked collateral is 3.17k. Yes, I played a bit with the collateral, but I think most of it is x2 or less. That means I have at least 1500 SC potential earnings. I suspect more because I had set the collateal to less than x2 for a while.

Image

Expected Behavior

If I set time to ALL I would expect that all active contracts would show as potential earnings.

Steps to Reproduce

  1. go to dashboard
  2. set time to all
  3. check potential and compare to actual money in contracts

Version

v2.3.5

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Docker on debian 12

Anything else?

There are probably more important issues related to v2 fork, but once those are solved it would be nice to have some good stats that reflect what's actually happening. This problem is not only when you select all. It's a bit tricky. if you want the earned to replace potential, then it should be on the time/height the potential is shown, not the time contract finished (if you want the stats to be accurate). But that's not really when the earnings came - they come when the contract is finished. So maybe don't try to cover potential with earned. Just show them side by side.
Maybe link 682 as related.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions