Skip to content

fix: remove ValidScopedCSSClass from recommended config (temp) #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aswamy merged 1 commit into from
Apr 17, 2026
Merged

fix: remove ValidScopedCSSClass from recommended config (temp) #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/disable-valid-scoped-css-class-recommended.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/theme-check-common': patch
'@shopify/theme-check-node': patch
---

Temporarily remove `ValidScopedCSSClass` from the recommended config. The check causes severe save lag in VS Code on larger themes (see [#1179](https://github.com/Shopify/theme-tools/issues/1179)) because it re-parses every `{% stylesheet %}` tag in the theme on every save. It remains available as an opt-in check. Will be re-enabled once the performance issue is resolved.
2 changes: 1 addition & 1 deletion packages/theme-check-common/src/checks/valid-scoped-css-class/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const ValidScopedCSSClass: LiquidCheckDefinition = {
docs: {
description:
'Reports CSS classes used in HTML class attributes that are not defined in any in-scope stylesheet tag or CSS asset file.',
recommended: true,
recommended: false,
url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/valid-scoped-css-class',
},
type: SourceCodeType.LiquidHtml,
Expand Down
3 changes: 0 additions & 3 deletions packages/theme-check-node/configs/recommended.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,6 @@ ValidSchemaName:
ValidSchemaTranslations:
enabled: true
severity: 0
ValidScopedCSSClass:
enabled: true
severity: 1
ValidSettingsKey:
enabled: true
severity: 0
Expand Down
Loading