Conversation
mattkubej
force-pushed
the
fix-spoom-load-crash
branch
from
ec3007f to
677c212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps Tapioca's Spoom lower bound to
>= 1.7.14and updates the checked-in lockfile to resolvespoom 1.7.14.spoom 1.7.13can crash at load time with newersorbet-runtimeversions while Tapioca is requiring Spoom fromlib/tapioca/internal.rb. The failure happens before Tapioca's RBS rewriter code is loaded, which is why it showed up as unrelated CI noise on #2616.Spoom 1.7.14 includes Shopify/spoom#911, which fixes the
Spoom::LSP::Hoverforward reference toRangethat triggered the Sorbet runtimeInvalid value for type constraint ... Got a NilClasscrash. Requiring this version prevents Bundler from selecting the brokenspoom 1.7.13+ newer Sorbet runtime combination in lockless/temp-Gemfile installs.