Add customer account menu web component#77
Merged
jessebreneman merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
rsomlette
approved these changes
Feb 19, 2026
karreiro
reviewed
Feb 24, 2026
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you for this PR, @jessebreneman!
Looks good to me. The only detail we might optimize is removing the settings in favor of the hard-coded menu value at sections/header.liquid:14.
That introduces a bit of ambiguity since merchants may reassign any kind of menu in that setting. To keep the Skeleton theme simple, we might lean on the hardcoded approach instead.
Thanks again for this PR!
karreiro
approved these changes
Feb 26, 2026
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you for the extra context shared offline, @jessebreneman!
Contributor
Author
|
@karreiro Thank you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new
<shopify-account>web component to the header, replacing the existing account link.