Open
Conversation
vinistock
force-pushed
the
05-07-default_method_alias_visibilities_to_public
branch
from
377d00d to
e9a3175
Compare
vinistock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not following alias targets to get the inherited visibility of an alias. Additionally, we were returning
Noneas the final fallback, which is reserved for declaration types where visibility simply doesn't apply (like ivars).This PR makes sure we follow aliases to detect the inherited visibility and I changed the final fallback to
publicin case we fail to determine the visibility of a method. I also movedTodotogether withClasssince it's basically the same thing.