Make SHOPIFY_CLI_APP_TEMPLATES_JSON_PATH work with SHOPIFY_CLI_1P_DEV
#6759
+131
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1P_DEV The template JSON override was only implemented in AppManagementClient, but when SHOPIFY_CLI_1P_DEV is enabled, PartnersClient is used instead. This adds the same override logic to PartnersClient so the env var works consistently regardless of which client is selected. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
billfienberg
changed the title
SHOPIFY_CLI_APP_TEMPLATES_JSON_PATH work with SHOPIFY_CLI_1P_DEV
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3589 tests passing in 1421 suites. Report generated by 🧪jest coverage report action from 42b7b0f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template JSON override was only implemented in AppManagementClient, but when SHOPIFY_CLI_1P_DEV is enabled, PartnersClient is used instead. This adds the same override logic to PartnersClient so the env var works consistently regardless of which client is selected.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist