fix: delete orphaned message notifications on conversation hard-delete#756
Open
ionfwsrijan wants to merge 2 commits into
Open
fix: delete orphaned message notifications on conversation hard-delete#756ionfwsrijan wants to merge 2 commits into
ionfwsrijan wants to merge 2 commits into
Conversation
Contributor
|
@ionfwsrijan is attempting to deploy a commit to the Shivayan's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@Shivayan09 You may review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a conversation is hard-deleted (all participants have soft-deleted it),
deleteConversationcleans up messages and the conversation document itself — but orphanedNotificationdocuments oftype: "message"are left behind referencing the now-deleted conversation.Changes
server/src/controllers/conversation.controller.js— AddedNotification.deleteMany({ conversation: convo._id, type: "message" })in theallDeletedbranch, before the conversation document is removed. This ensures orphaned notifications are cleaned up atomically with the conversation deletion.Impact
.populate("conversation")from returning null references for deleted conversationsFixes #753