fix: theme/language select dropdown unreadable in dark mode#23
Open
Matcry12 wants to merge 1 commit intoShipWithAI:developfrom
Open
fix: theme/language select dropdown unreadable in dark mode#23Matcry12 wants to merge 1 commit intoShipWithAI:developfrom
Matcry12 wants to merge 1 commit intoShipWithAI:developfrom
Conversation
Starlight's Select component uses --sl-color-bg-nav for dropdown option backgrounds, which resolves to --sl-color-gray-6. Our design system overrides gray-6 to a near-transparent accent color, causing dropdown options to render as white text on white background. Fix by explicitly setting --sl-color-bg-nav to a solid surface color in both dark and light themes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@Matcry12 is attempting to deploy a commit to the Ethan Nguyen's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: Our custom CSS overrides
--sl-color-gray-6to a near-transparent color, but Starlight uses that variable for dropdown backgrounds (--sl-color-bg-nav).Fix: Set
--sl-color-bg-navto a solid background color for both dark and light themes.What does this PR do?
Makes the Dark/Light/Auto and English/Tiếng Việt dropdown options readable in both themes.
Checklist
npm run devContent follows 7-block structure(CSS-only, no content changes)Vietnamese version updated(not applicable)