🎨 Palette: Add keyboard shortcuts for primary actions#120
Conversation
Implemented keyboard shortcuts (Ctrl+Enter / Cmd+Enter) for the main action button to enhance accessibility for power users. Refactored the DOM loading state to preserve child nodes rather than destroying nested `<kbd>` visual elements. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Implemented a global keyboard shortcut (
Ctrl+EnterandMeta+Enter) to trigger the primary action button, along with visual<kbd>hints on the button itself. To support these nested elements, the loading state saving mechanism was refactored from savingtextContentto savingchildNodes.🎯 Why:
To provide a more intuitive and accessible experience for keyboard and power users, reducing reliance on mouse navigation for primary interactions.
📸 Before/After:
Before: The action button only displayed "Click Me (Accessible)" and required a mouse click or standard
Tab/Spacenavigation.After: The button explicitly hints the shortcut "Click Me (Accessible)
Ctrl+Enter". The keyboard shortcut immediately focuses and clicks the button, and the DOM restoration cleanly restores the nested elements.♿ Accessibility:
aria-keyshortcuts="Control+Enter Meta+Enter"to the button to explicitly declare the shortcut to screen readers.<kbd>elements to implicitly declare the shortcut to sighted users.preventDefault()and activelyfocus()es the button to ensure screen readers track the active interaction context.PR created automatically by Jules for task 9205861562448097540 started by @Shin5hi