Skip to content

🎨 Palette: Add keyboard shortcuts for primary actions#120

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette-keyboard-shortcuts-9205861562448097540
Draft

🎨 Palette: Add keyboard shortcuts for primary actions#120
Shin5hi wants to merge 1 commit into
mainfrom
palette-keyboard-shortcuts-9205861562448097540

Conversation

@Shin5hi
Copy link
Copy Markdown
Owner

@Shin5hi Shin5hi commented Apr 10, 2026

💡 What:

Implemented a global keyboard shortcut (Ctrl+Enter and Meta+Enter) to trigger the primary action button, along with visual <kbd> hints on the button itself. To support these nested elements, the loading state saving mechanism was refactored from saving textContent to saving childNodes.

🎯 Why:

To provide a more intuitive and accessible experience for keyboard and power users, reducing reliance on mouse navigation for primary interactions.

📸 Before/After:

Before: The action button only displayed "Click Me (Accessible)" and required a mouse click or standard Tab/Space navigation.
After: The button explicitly hints the shortcut "Click Me (Accessible) Ctrl+Enter". The keyboard shortcut immediately focuses and clicks the button, and the DOM restoration cleanly restores the nested elements.

♿ Accessibility:

  • Added aria-keyshortcuts="Control+Enter Meta+Enter" to the button to explicitly declare the shortcut to screen readers.
  • Added visual <kbd> elements to implicitly declare the shortcut to sighted users.
  • Ensured the shortcut handler triggers preventDefault() and actively focus()es the button to ensure screen readers track the active interaction context.

PR created automatically by Jules for task 9205861562448097540 started by @Shin5hi

Implemented keyboard shortcuts (Ctrl+Enter / Cmd+Enter) for the main action button to enhance accessibility for power users. Refactored the DOM loading state to preserve child nodes rather than destroying nested `<kbd>` visual elements.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7080f35d-2a69-4f15-9e49-e0113674dda7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-keyboard-shortcuts-9205861562448097540

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant