0918#1
Open
Shin-Yun-Cheol wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a commenting system for the existing user and post management system. The changes include creating comment entities, controllers, services, and DTOs, along with establishing proper relationships between users, posts, and comments.
- Added complete comment CRUD functionality (create, update, delete)
- Implemented proper entity relationships with cascade deletes and orphan removal
- Renamed classes for consistency and added user account deletion feature
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/mission/e2e/BoardE2ETest.java | E2E test for comment CRUD operations |
| src/main/java/mission/user/dto/DeleteUserRequest.java | New DTO for user account deletion requests |
| src/main/java/mission/user/UserService.java | Added user account deletion functionality |
| src/main/java/mission/user/UserController.java | Added DELETE endpoint for user accounts |
| src/main/java/mission/user/User.java | Added relationships to posts and comments with cascade settings |
| src/main/java/mission/post/dto/PostUpdateRequest.java | Renamed from UpdatePostRequest for consistency |
| src/main/java/mission/post/PostService.java | Updated to use renamed PostUpdateRequest |
| src/main/java/mission/post/PostController.java | Updated to use renamed PostUpdateRequest |
| src/main/java/mission/post/Post.java | Added relationship to comments with cascade settings |
| src/main/java/mission/comment/dto/CommentUpdateRequest.java | DTO for comment update requests |
| src/main/java/mission/comment/dto/CommentResponse.java | DTO for comment responses |
| src/main/java/mission/comment/dto/CommentDeleteRequest.java | DTO for comment deletion requests |
| src/main/java/mission/comment/dto/CommentCreateRequest.java | DTO for comment creation requests |
| src/main/java/mission/comment/CommentService.java | Service layer for comment operations |
| src/main/java/mission/comment/CommentRepository.java | JPA repository for comment persistence |
| src/main/java/mission/comment/CommentController.java | REST controller for comment endpoints |
| src/main/java/mission/comment/Comment.java | Comment entity with relationships |
| src/main/java/mission/Exception/GlobalExceptionHandler.java | Fixed package name from mission.common to mission.Exception |
| request.http | Removed all content |
Files not reviewed (1)
- .idea/gradle.xml: Language not supported
Comments suppressed due to low confidence (1)
src/main/java/mission/user/User.java:1
- There's a typo in the comment. '댓글듣' should be '댓글들' (comments).
package mission.user;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @JoinColumn(name = "author") | ||
| private User author; | ||
|
|
||
| // 이 글의 댓글들 ( 글 삭제 시 댓글도 함꼐 삭제) |
There was a problem hiding this comment.
There's a typo in the comment. '함꼐' should be '함께' (together).
Suggested change
| // 이 글의 댓글들 ( 글 삭제 시 댓글도 함꼐 삭제) | |
| // 이 글의 댓글들 ( 글 삭제 시 댓글도 함께 삭제) |
Shin-Yun-Cheol
requested review from
seulnan
and removed request for
seulnan
September 19, 2025 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.