🎨 Palette: 移除底部控制栏冗余的无障碍标签 - #75
Shangjin-Xiao wants to merge 2 commits into
Conversation
- 💡 内容: 移除了静音、动态照片和元数据保留按钮内 `Icon` 的重复 `contentDescription`。 - 🎯 原因: 父级 `IconButton` 已经通过 `Modifier.semantics` 提供无障碍标签，内部 `Icon` 如果再次提供会导致屏幕阅读器重复播报，产生冗余。 - 📸 效果: 代码级改进，无视觉变化。 - ♿ 无障碍: 修复了屏幕阅读器的冗余播报问题，提升了无障碍体验。 Co-authored-by: Shangjin-Xiao <84136399+Shangjin-Xiao@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
- 💡 内容: 移除了静音、动态照片和元数据保留按钮内 `Icon` 的重复 `contentDescription`，并移除了 `.github/workflows/ci.yml` 和 `release.yml` 中的 `android-actions/setup-android@v3` 步骤。 - 🎯 原因: 父级 `IconButton` 已经通过 `Modifier.semantics` 提供无障碍标签，内部 `Icon` 如果再次提供会导致屏幕阅读器重复播报。此外，`setup-android` 在较新环境因 `tools` 包弃用而导致 CI 失败，且 `ubuntu-latest` 已经内置了相关 SDK 环境。 - 📸 效果: 代码级改进与 CI 修复，无视觉变化。 - ♿ 无障碍: 修复了屏幕阅读器的冗余播报问题，提升了无障碍体验。 Co-authored-by: Shangjin-Xiao <84136399+Shangjin-Xiao@users.noreply.github.com>
1 participant
Icon的重复contentDescription。IconButton已经通过Modifier.semantics提供无障碍标签，内部Icon如果再次提供会导致屏幕阅读器重复播报，产生冗余。PR created automatically by Jules for task 11624313455004282606 started by @Shangjin-Xiao
Summary by cubic
Removes redundant accessibility labels from the mute, motion photo, and metadata preserve buttons in the player bottom bar, and drops the
android-actions/setup-androidstep from CI and release workflows.The parent
IconButtonalready provides a semantic label, so the innerIcon'scontentDescriptionmade screen readers announce the label twice. The removed CI step relied on a deprecated tools package and wasn't needed sinceubuntu-latestalready includes the SDK. No visual change.Written for commit a14ba1a. Summary will update on new commits.