-
Notifications
You must be signed in to change notification settings - Fork 18
[CI] update all ubuntu20 jobs to ubuntu22 (ubuntu 20 EOL) #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Summary of ChangesHello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the continuous integration environment by upgrading the underlying operating system from Ubuntu 20 to Ubuntu 22. This change is crucial for maintaining a supported and secure build infrastructure, as Ubuntu 20 has reached its End-of-Life. The update ensures that all CI jobs will run on a current and actively maintained platform. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Dockerfile for phys_test_image_acpp_omp to use an Ubuntu 22 base image instead of Ubuntu 20. This is a good proactive measure given Ubuntu 20's approaching end-of-life, ensuring the CI environment remains secure and up-to-date. The change itself is correct. However, the pull request title suggests a wider scope ('update all ubuntu20 jobs') than the single file change. If other files require this update, they should be included to ensure consistency. Otherwise, consider narrowing the PR title to more accurately reflect the changes made.
Workflow reportworkflow report corresponding to commit 103a3d1 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
No description provided.