Skip to content

Conversation

@tdavidcl
Copy link
Member

@tdavidcl tdavidcl commented Jan 1, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@gemini-code-assist
Copy link

Summary of Changes

Hello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the continuous integration environment by upgrading the underlying operating system from Ubuntu 20 to Ubuntu 22. This change is crucial for maintaining a supported and secure build infrastructure, as Ubuntu 20 has reached its End-of-Life. The update ensures that all CI jobs will run on a current and actively maintained platform.

Highlights

  • CI Environment Update: Migrated the base Docker image for CI from ubuntu20 to ubuntu22 to address the End-of-Life status of Ubuntu 20, ensuring a supported and secure build environment.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/env_tests.yml
    • .github/workflows/shamrock-acpp-clang-asan.yml
    • .github/workflows/shamrock-acpp-clang-coverage.yml
    • .github/workflows/shamrock-acpp-clang-py.yml
    • .github/workflows/shamrock-acpp-clang-ubsan.yml
    • .github/workflows/shamrock-dpcpp.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfile for phys_test_image_acpp_omp to use an Ubuntu 22 base image instead of Ubuntu 20. This is a good proactive measure given Ubuntu 20's approaching end-of-life, ensuring the CI environment remains secure and up-to-date. The change itself is correct. However, the pull request title suggests a wider scope ('update all ubuntu20 jobs') than the single file change. If other files require this update, they should be included to ensure consistency. Otherwise, consider narrowing the PR title to more accurately reflect the changes made.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Workflow report

workflow report corresponding to commit 103a3d1
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
ruff check...............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 7622 → 7622 (0.0%)

Detailed changes :

@tdavidcl tdavidcl merged commit 28e3842 into Shamrock-code:main Jan 3, 2026
62 checks passed
@tdavidcl tdavidcl deleted the patch-2026-01-01-09-03 branch January 3, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant