[Ramses][Solvergraph] AMR level zero sizes #1418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of ChangesHello @Akos299, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Ramses solver by adding a dedicated component to its solvergraph that computes the fundamental cell sizes at level zero for each patch. This foundational data is crucial for the subsequent stages of adaptive mesh refinement, enabling more accurate determination of AMR levels for individual blocks within the simulation patches. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new solver graph node, ComputeLevel0CellSize, to determine the size of level 0 cells for each patch, which is a logical addition for AMR calculations. The implementation is straightforward and fits well within the existing architecture. I've identified a couple of minor areas for improvement regarding code cleanliness, such as removing an unused type alias and marking an unused parameter. Additionally, there's a redundant type definition in Solver.cpp that should be removed to improve maintainability. Overall, the changes are sound and I've provided specific suggestions to address these points.
src/shammodels/ramses/include/shammodels/ramses/modules/ComputeLevel0CellSize.hpp
Outdated
Show resolved
Hide resolved
src/shammodels/ramses/include/shammodels/ramses/modules/ComputeLevel0CellSize.hpp
Outdated
Show resolved
Hide resolved
[Ramses][Solvergraph] AMR level zero sizes Added a solvergraph node to compute level zero sizes for each patch. This will be used for instance to compute the amr level for blocks in each patch. updates
Akos299
force-pushed
the
features/level0sizes
branch
from
79e800a to
42a7b2e
Compare
Workflow reportworkflow report corresponding to commit 42a7b2e Light CI is enabled. This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Doxygen diff with
|
tdavidcl
requested changes
Dec 27, 2025
| solver_sequence.push_back(std::make_shared<decltype(node)>(std::move(node))); | ||
| } | ||
|
|
||
| { // compute level0 sizes in patch |
Member
There was a problem hiding this comment.
can we make this optional using the solverconfig. This node will not be used for the base solver so it should not be enabled in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a solvergraph node to compute level zero sizes for each patch. This will be used for instance to compute the amr level for blocks in each patch.