[Ramses][AMR][RefinementHandler] Enforce 2:1 rule #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of ChangesHello @Akos299, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a critical enhancement to the Adaptive Mesh Refinement (AMR) system by implementing and enforcing the 2:1 refinement rule. This rule is vital for maintaining the structural integrity and computational efficiency of adaptive grids by preventing large jumps in resolution between neighboring blocks. The changes involve adding new data structures to track block refinement levels and a parallel kernel to apply the rule, alongside significant documentation updates to improve code clarity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new block_levels field to SolverStorage and implements a SYCL kernel in AMRGridRefinementHandler to enforce the 2:1 refinement restriction using block neighbor graphs and block levels. It also adds extensive Doxygen comments to clarify the purpose of graph building nodes (FindBlockNeigh, BlockNeighToCellNeigh) and AMR-related functions. Review comments address a critical race condition in the new SYCL kernel, recommending the use of sycl::atomic_ref for atomic updates, and suggest removing commented-out code, clarifying ambiguous comments, correcting typos in documentation, and refactoring repetitive code blocks for better maintainability.
src/shammodels/common/include/shammodels/common/amr/NeighGraph.hpp
Outdated
Show resolved
Hide resolved
For each patch get its size Compute for each patch the amr level of its blocks
Add linear interpolation for new childs fields. For each cell to be refined get slopes of its conservative fields. Then perform linear interpolation to fill its news eight children. At the end performed renormalisation to enforce conservation. TODO: extend this such that it takes into high order interpolations
- Add new node to compute AMR level in solvergraph - Add new module + new node to compute level0 size for each patch - fix previous bug for unexisting ptr. - TODO1 slope limiter gives 0 find what is wrong and fix it - TODO2 Add another refinement criterion + tests
In the previous commit, slopes limiter using ConsState variables gave rise to NaN. By switching to field by field approach, we get no more NaN. This will be investigate further since the first approach is more optimal than the first one. We also change the interpolation method. And check that conservative enforcement is respected.
Implemented the normalized refinement criterion as describe in the paper of ENZO. Add in NeighGraph a complete_event state function which operates on sham::EventList.
Workflow reportworkflow report corresponding to commit 3427b0c Light CI is enabled. This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Doxygen diff with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tdavidcl @bcommerc , I added the linear interpolation to fill children cells.
Doing this, I reused the cells graph. compute slope limiter for conservatives variables,
interpolate parent cell fields and renormalize to ensure conservation.
I would like to have your feedback about this.