Fix path boundary matching in project directory filtering#37
Draft
ShadowDog007 with Copilot wants to merge 2 commits into
Draft
Fix path boundary matching in project directory filtering#37ShadowDog007 with Copilot wants to merge 2 commits into
ShadowDog007 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: ShadowDog007 <3084997+ShadowDog007@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality to list csproj projects in repository
Fix path boundary matching in project directory filtering
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--changed-in,--changed-from, and--changed-tofilters incorrectly matched projects when one project's directory name was a prefix of another (e.g.,/ProjectAmatching changes in/ProjectAExtensions).Root Cause
String.startsWithwas used for path matching without enforcing a path boundary separator:This caused false positives in two places:
BaseProjectFilterCommand.filterChangedFromTo— matching changed files to project dirsRepositoryService.getLatestPathVersion— matching uncommitted changes to project pathsFix
BaseProjectFilterCommand.ts:c.startsWith(d)→c === d || c.startsWith(d + '/')RepositoryService.ts: same fix for uncommitted path matching, with special-casing for the root path/Tests Added
RepositoryService.spec.ts: uncommitted change in/ProjectAExtensions/file.csmust not affectgetLatestPathVersion('/ProjectA')ListCommand.spec.ts:--changed-inscoped toproject1extensions/must not match theproject1project🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.