Skip to content

Update UART fabric#514

Merged
AwesomeTornado merged 4 commits into
feature/dcp-amds-corefrom
feature/dcp-amds-core-most-basic-uart-fix
Jun 10, 2026
Merged

Update UART fabric#514
AwesomeTornado merged 4 commits into
feature/dcp-amds-corefrom
feature/dcp-amds-core-most-basic-uart-fix

Conversation

@AwesomeTornado

Copy link
Copy Markdown
Member

Closes #505 & #502
@elsevers

Notes

This has been tested on my single AMDS setup and through simulation. It has not been run on anyone else's hardware yet.

The testbench code is unfortunately messy due to me restarting this project three times.

Self-Review

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@AwesomeTornado AwesomeTornado self-assigned this Jun 8, 2026
@AwesomeTornado AwesomeTornado requested a review from elsevers as a code owner June 8, 2026 22:23
@elsevers

elsevers commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Excellent @AwesomeTornado! I understand it passes the verilog testbench. Do we also have test validation in hardware (i.e., on @knvprasad-dr's hardware)?

@AwesomeTornado

AwesomeTornado commented Jun 9, 2026 via email

Copy link
Copy Markdown
Member Author

@AwesomeTornado

Copy link
Copy Markdown
Member Author

@elsevers I have tested this and confirmed it to be working on @knvprasad-dr's hardware.

image

I believe the Jupyter notebook is a bit out of date, but the graphs look the same between this branch and the previous one.

@elsevers elsevers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge!

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

@AwesomeTornado AwesomeTornado merged commit e9b0307 into feature/dcp-amds-core Jun 10, 2026
1 check passed
@AwesomeTornado AwesomeTornado deleted the feature/dcp-amds-core-most-basic-uart-fix branch June 10, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants