Skip to content

Bugfix: Query suggestions only work after more than 3 characters are typed and a character is deleted #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Garneauma merged 1 commit into from
Aug 11, 2026
Merged

Bugfix: Query suggestions only work after more than 3 characters are typed and a character is deleted #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/connector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,10 +964,16 @@ function initEngine() {
if ( searchBoxElement ) {
searchBoxElement.onkeydown = ( e ) => {
// Enter
if ( e.keyCode === 13 && ( activeSuggestion !== 0 && suggestionsElement && !suggestionsElement.hidden ) ) {
selectSuggestion();
closeSuggestionsBox();
e.preventDefault();
if ( e.keyCode === 13 ) {

// Save that the last input change came from the Enter key so QS doesn't reopen after a search is submitted
lastCharKeyUp = 13;

if ( activeSuggestion !== 0 && suggestionsElement && !suggestionsElement.hidden ) {
selectSuggestion();
closeSuggestionsBox();
e.preventDefault();
}
}
// Escape or Tab
else if ( e.keyCode === 27 || e.keyCode === 9 ) {
Expand All @@ -993,16 +999,14 @@ function initEngine() {
}
}
};
searchBoxElement.onkeyup = ( e ) => {
searchBoxElement.onkeyup = () => {
waitForkeyUp = false;
lastCharKeyUp = e.keyCode;
// Keys that don't changes the input value
if ( ( e.key.length !== 1 && e.keyCode !== 46 && e.keyCode !== 8 ) || // Non-printable char except Delete or Backspace
( e.ctrlKey && e.key !== "x" && e.key !== "X" && e.key !== "v" && e.key !== "V" ) ) { // Ctrl-key is pressed but not X or V is use
return;
}
};

// Use the "input" events to detect text changes (better support across devices, e.g., Android)
searchBoxElement.oninput = ( e ) => {
lastCharKeyUp = null;

// Any other key
if ( searchBoxController.state.value !== e.target.value ) {
searchBoxController.updateText( stripHtml( e.target.value ) );
}
Expand Down
28 changes: 16 additions & 12 deletions src/suggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,16 @@ function initEngine() {
if ( searchBoxElement ) {
searchBoxElement.onkeydown = ( e ) => {
// Enter
if ( e.keyCode === 13 && ( activeSuggestion !== 0 && suggestionsElement && !suggestionsElement.hidden ) ) {
selectSuggestion();
closeSuggestionsBox();
e.preventDefault();
if ( e.keyCode === 13 ) {

// Save that the last input change came from the Enter key so QS doesn't reopen after a search is submitted
lastCharKeyUp = 13;

if ( activeSuggestion !== 0 && suggestionsElement && !suggestionsElement.hidden ) {
selectSuggestion();
closeSuggestionsBox();
e.preventDefault();
}
}
// Escape or Tab
else if ( e.keyCode === 27 || e.keyCode === 9 ) {
Expand All @@ -209,16 +215,14 @@ function initEngine() {
}
}
};
searchBoxElement.onkeyup = ( e ) => {
searchBoxElement.onkeyup = () => {
waitForkeyUp = false;
lastCharKeyUp = e.keyCode;
// Keys that don't changes the input value
if ( ( e.key.length !== 1 && e.keyCode !== 46 && e.keyCode !== 8 ) || // Non-printable char except Delete or Backspace
( e.ctrlKey && e.key !== "x" && e.key !== "X" && e.key !== "v" && e.key !== "V" ) ) { // Ctrl-key is pressed but not X or V is use
return;
}
};

// Use the "input" events to detect text changes (better support across devices, e.g., Android)
searchBoxElement.oninput = ( e ) => {
lastCharKeyUp = null;

// Any other key
if ( e.target.value ) {
updateSearchBoxText( sanitizeQuery( e.target.value ) );
}
Expand Down
Loading