add trigger custom click event - #70
Conversation
|
@bblaisATcoveo Est-ce que ce qui suit est le genre de payload qui devrait être dans l'évènement triggered? C'est un peu difficile à évaluer puisqu'aucun nom de propriété match l'évènement qui est envoyé dans connector.js (type, meta, evt), mais c'est la différence que j'ai remarqué avec la version released. Merci! Si c'est bien cela, c'est approuvé. |
|
@Garneauma oui c'est bien l'événement attendu, on regarde "eventType" et "eventValue" pour confirmer que c'est bien un click sur un trigger. |
|
I simply resolved the merge conflict. @cfoss-coveo Please review and test. Once (and if) we receive positive feedback from you, this PR can be merged by @Garneauma. Thanks! |
cfoss-coveo
left a comment
There was a problem hiding this comment.
Happy to approve to get this out the door, but in my testings, the logging wasn't 100% reliable.
I think what's happening is on page navigation (i.e., clicking a link), the browser cancels all pending requests. This includes the request logging the custom trigger event. The suggested changes just pauses page navigation briefly for the analytics event to be logged.
|
@GormFrank @Garneauma This is safe to deploy, but see my comment above. |
|
@cfoss-coveo We'll leave as-is for now as this needs to get out. We'll have to keep this in mind if we have issues with event logs. |
|
@ServiceCanada/sc-release-management For your review. |
TEST CASE 1 :