Skip to content

CENS-122: Dependencies Upgrade - #132

Open
gc-josephdiab wants to merge 13 commits into
ServiceCanada:masterfrom
gc-josephdiab:dependencies
Open

CENS-122: Dependencies Upgrade#132
gc-josephdiab wants to merge 13 commits into
ServiceCanada:masterfrom
gc-josephdiab:dependencies

Conversation

@gc-josephdiab

Copy link
Copy Markdown

No description provided.

@gc-josephdiab
gc-josephdiab requested a review from a team August 3, 2026 19:46
@jonasg-gc jonasg-gc changed the title Dependencies Upgrade CENS-122: Dependencies Upgrade Aug 4, 2026

@jonasg-gc jonasg-gc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending testing

Comment thread server.js
Comment on lines +312 to +322
async function shutdown() {
server.close();
await Promise.all([
subsController.closeWorker(),
bulkApiMailer.closeWorker(),
notifyQueue.closeQueues()
]);
}

process.once('SIGTERM', shutdown);
process.once('SIGINT', shutdown);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: hWhy?

@jonasg-gc

Copy link
Copy Markdown
Collaborator

@BeraJosh : Need Security review. In GitHub and Jira

Comment thread package.json
"@bull-board/express": "^6.21.3",
"aws-sdk": "^2.1692.0",
"bull": "^4.16.5",
"body-parser": "^2.3.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security:
New Dependency
https://www.npmjs.com/package/body-parser
138.4M weekly downloads
Latest update 2026-06-15
@ServiceCanada/sc-pull-request-approvers

Comment thread package.json
"aws-sdk": "^2.1692.0",
"bull": "^4.16.5",
"body-parser": "^2.3.0",
"bullmq": "^5.71.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security:
New Dependency
https://www.npmjs.com/package/bullmq
7.8M weekly downloads
v5.81.3 was released 2026-07-29. The ^ will fetch it. v.6 was recently released but too many breaking changes for now. v5 still seems to be supported.
@ServiceCanada/sc-pull-request-approvers

Comment thread package.json
"dotenv": "^16.6.1",
"entities": "^8.0.0",
"errorhandler": "^1.5.2",
"express": "^5.2.1",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version update

Comment thread docker-compose.yml
services:
notify-mongo-1:
image: mongo:4.4.30
image: mongo:8.0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major major version update

Comment thread docker-compose.yml

notify-redis-1:
image: redis:6.2.0
image: redis:8.0-alpine

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major major version update

Comment thread Dockerfile
@@ -1,4 +1,4 @@
FROM node:20.20.0-bookworm-slim
FROM node:24.14.1-bookworm-slim

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants