refactor(mp4): move ftyp field to Mp4Properties#650
Merged
Serial-ATA merged 3 commits intoSerial-ATA:mainfrom Apr 22, 2026
Merged
refactor(mp4): move ftyp field to Mp4Properties#650Serial-ATA merged 3 commits intoSerial-ATA:mainfrom
Serial-ATA merged 3 commits intoSerial-ATA:mainfrom
Conversation
The `ftyp` field is moved from `Mp4File` to `Mp4Properties` to ensure consistency in how format-specific properties are stored and accessed. This change also updates documentation and tests to reflect the new structure.
Serial-ATA
requested changes
Apr 21, 2026
Owner
Serial-ATA
left a comment
Serial-ATA
left a comment
There was a problem hiding this comment.
Thanks! Just one note on the docs
Serial-ATA
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ftypfield is moved fromMp4FiletoMp4Propertiesto ensure consistency in how format-specific properties are stored and accessed. This change also updates documentation and tests to reflect the new structure.I had to update the MP4 test property constants to functions, since
Stringcan't be constructed withconst.Fixes #287