misc: replace OnceLock with LazyLock#649
Merged
Serial-ATA merged 2 commits intoSerial-ATA:mainfrom Apr 24, 2026
Merged
Conversation
Replace `std::sync::OnceLock` with `std::sync::LazyLock` for static initializations in `upgrade.rs`, `write/mod.rs`, `resolve.rs`, and `tag/item.rs` to simplify lazy initialization logic.
Serial-ATA
requested changes
Apr 22, 2026
…ERS static Replace the `custom_resolvers()` function with a global `CUSTOM_RESOLVERS` `LazyLock` static to simplify access and align with the transition from `OnceLock` to `LazyLock`. This also includes refactoring the CRC32 table to use a static `LazyLock` instead of a function.
Serial-ATA
changed the title
OnceLock with LazyLock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced
std::sync::OnceLockwithstd::sync::LazyLockfor static initializations inupgrade.rs,write/mod.rs,resolve.rs, andtag/item.rsto simplify lazy initialization logic and fix #441lofty/src/tag/items/popularimeter.rsusesOnceLockwith.set()and can't be converted toLazyLockwithout bigger API changes. That's why I left it :)