Repository navigation
docs: formalise Phase 2 owner decisions - #8
Merged
Merged
Conversation
Record two owner decisions made on 2026-11-04 before Phase 2: - Accept ADR-0020: Filament for platform administration at /admin (staff only, English-only, Phase 2 tokens, use cases only, Laravel 13 check in Phase 3 with fallback). Vendor dashboard stays Vue + Inertia. Adds the surface-separation and language clauses, and notes that the ADR-0011 mechanisms it relies on are still Proposed. - Approve P-1: guest browsing and cart; account-required checkout with inline registration; verified email before order submission and payment initiation; resume checkout after verification. Resolve Phase 1 briefing C7 (P-1 inline sign-up vs FR-ID-01 redirect): verification becomes a step inside checkout. The signed 60-minute link is unchanged. Amend FR-ID-01, FR-CART-02, FR-CHK-01, CJ-1, ADR-0015 §1 and security-model §5 routing to enforce it consistently. Scope PRD §6.1, gate 7 and NFR-I18N-01 to the storefront and vendor UI, because the admin is English-only (briefing C13). Record everything in PHASE-1-REVIEW Addendum A. Documentation only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This records two owner decisions made on 2026-11-04 before Phase 2 (Brand Identity and Design System), and resolves the contradiction they exposed. Documentation only: no application code, dependencies, configuration, migrations or generated files.
Summary
Decision 1: ADR-0020 is Accepted (it was Proposed).
platform_role, permission-enum andVendorContextmechanisms come from ADR-0011, which stays Proposed. ADR-0020 says explicitly that they are not accepted until ADR-0011 is.Decision 2: P-1 is approved. Checkout flow:
Phase 1 briefing C7 is resolved. P-1's inline sign-up contradicted FR-ID-01's "redirected to verification". Verification is now a step inside checkout, and the signed link and its 60-minute lifetime are unchanged.
These C-numbers come from the Phase 1 decision briefing. They are not Phase 0's code findings C1–C6, and Addendum A says so.
Consistency (briefing C13). Because the admin is English-only, three statements that implied every page is translated are now scoped to the storefront and vendor dashboard: PRD §6.1, release gate 7 and NFR-I18N-01.
Files (9)
docs/architecture/adr/0020-platform-administration-in-filament.mddocs/architecture/README.mddocs/product/product-requirements.mddocs/product/functional-requirements.mddocs/product/user-journeys.mddocs/architecture/adr/0015-checkout-and-payment-orchestration.mddocs/architecture/security-model.mdcheckoutroute group (public entry; place and pay need auth + verified; use cases re-check)docs/product/non-functional-requirements.mddocs/discovery/PHASE-1-REVIEW.mdEvidence
Verified before committing:
docs/;git diff --checkis clean;Accepted, by owner decision (2026-11-04);Proposed, both in the ADR file and in the index;marketplace-migration.md→../REDESIGN_BRIEF.md. It was already broken before this PR:main;main.CI note
The
PHP 8.5 / Laravel 13job is expected to fail atcomposer audit. Five dependency advisories were published aftermainlast passed CI. The fix is in #7, which is open with CI passing, and is waiting for a required review.This PR touches only Markdown and deliberately does not work around that failure. Re-run CI here once #7 has merged.
Merge Danger
Door: two-way
Documentation only, so a revert restores the previous wording. The decisions themselves are owner approvals; reversing one would need a new ADR under ADR-0006.
Blast Radius: docs
There is no runtime effect. The change does steer Phase 2 scope (admin theming only, no admin RTL) and the Phase 3 checkout implementation.