Repository navigation
Cut 2.4.1 - #33
Merged
Merged
Cut 2.4.1#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release prep. Everything already merged; this moves
[Unreleased]under a version heading and bumps the version.What 2.4.1 contains
Both halves of one problem — how a profile is found, and whether the name it is found by agrees with the name it reports.
A profile whose
idand filename disagree is refused at load (#30, closes #25). Lookup resolves by filename; every finding, JSON report and SARIF run then carries theid. A file namedmy-policy.yamldeclaringid: acme-baselineloaded under--profile my-policyand reportedacme-baselinethroughout, so grepping CI output for the name that was invoked found nothing.extendsresolves by filename whileexcludestargets theid, so composition saw the same split.The filename's spelling is confirmed on disk (#31).
os.path.isfileanswers the filesystem's question rather than this tool's, soAcme-Baseline.yamldeclaringid: acme-baselineresolved on macOS and Windows and failed with "Profile not found" on Linux — the same overlay working on a laptop and failing in CI. That also made the check above weaker than it read: it was comparing the name that was asked for against theidrather than the name that exists.Profile not foundnow explains the convention and names the file it looked for, because a correctly written overlay under the wrong filename produced a bare "not found" that sent readers hunting for a missing file.Patch, not minor
No new surface. Two bug fixes, better error messages, and a test correction. Nothing that resolved before stops resolving, except overlays that were already failing on Linux or already reporting a name nobody invoked.
Adopter impact
An overlay whose
idand filename disagree, or whose filename differs only by case, now fails to load rather than half-working. That is the intent — both were already broken, quietly or on another platform — and both messages name the file they expected.The bundled catalog is unaffected: a parametrised test asserts all 15 profiles satisfy the rule.
Also in here
A test fix for ospac 1.7.0 (#32), which added
"the apache license, version 2.0"to its aliases and moved that spelling from the descriptive-key path to the exact-alias path. Test-only — no behaviour changed, and the licence still resolves toApache-2.0.Checks
pyproject.toml,src/ossbomer/__init__.pyand the compare link all at 2.4.1python -m buildproduces both artifacts;twine checkpasses on eachTagging
v2.4.1once this lands, which triggers the PyPI publish.