Retry AWS (S3) requests for network errors#46
Open
rdettai-sk wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Quickwit’s AWS error classification so that S3 SDK “dispatch failures” (request send/connection-level failures) are treated as retryable by Quickwit’s aws_retry wrapper, improving resilience to transient network errors.
Changes:
- Mark
aws_sdk_s3::error::SdkError::DispatchFailure(_)as retryable in theAwsRetryableimplementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
36
to
40
| SdkError::ConstructionFailure(_) => false, | ||
| SdkError::TimeoutError(_) => true, | ||
| SdkError::DispatchFailure(_) => false, | ||
| SdkError::DispatchFailure(_) => true, | ||
| SdkError::ResponseError(_) => true, | ||
| SdkError::ServiceError(error) => error.err().is_retryable(), |
rdettai-sk
force-pushed
the
retry-on-dispatch-failure
branch
from
98f69e5 to
ca04959
Compare
Darkheir
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It is quite surprising that dispatch failures are not retried, they typically occur with:
How was this PR tested?
Describe how you tested this PR.