Enable streaming doc fetch added in PR42#45
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR switches SearchServiceClient::fetch_docs to use the new gRPC server-streaming endpoint (introduced in PR #42) to receive fetched documents in batches, avoiding gRPC message size limits while preserving the existing FetchDocsResponse API.
Changes:
- Replace unary
fetch_docsgRPC call withstream_fetch_docsand aggregate streamed batches into a singleFetchDocsResponse. - Add
TryStreamExtusage to fold the streamed responses into a pre-allocatedVec.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+160
to
+163
| .map_err(|tonic_error| parse_grpc_error(&tonic_error))? | ||
| .into_inner() | ||
| .map_err(|tonic_error| parse_grpc_error(&tonic_error)) | ||
| .try_fold( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GRPC was added in #42 and deployed. We can now use it.
How was this PR tested?
Describe how you tested this PR.