Change max_num_concurrent_split_searches to cover entire split duration#44
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the search permit system so max_num_concurrent_split_searches limits the full lifetime of a split search (warmup + CPU search), rather than only limiting warmup/download concurrency. This aligns the behavior with the setting’s name and improves control over search-time resource pressure.
Changes:
- Hold the concurrency “slot” for the entire split search duration; release it only when the
SearchPermitis dropped. - Remove the warmup-slot early-release mechanism (
free_warmup_slot/FreeWarmupSlotmessage) and simplify permit drop bookkeeping. - Update the affected unit test and remove the warmup-slot release call from leaf search execution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| quickwit/quickwit-search/src/search_permit_provider.rs | Reworks permit slot semantics to cover full split search duration and updates related tests/messages. |
| quickwit/quickwit-search/src/leaf.rs | Stops freeing the permit slot after warmup so the slot remains held until split search completion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Darkheir
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently max_num_concurrent_split_searches limits the number of parallel warmups. Its name suggests that it isn't released until the split search is complete. This is also what we would want to better control memory pressure.
How was this PR tested?
Describe how you tested this PR.