3-5 New Charts by ekoslow1-creator · Pull Request #4 · Sefaria/powered-by

ekoslow1-creator · 2026-07-29T06:29:51Z

New charts for the dashboard

…r bucketing Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…pty experience trend - getToolUsageCounts now filters sefaria_tools_used to string entries before normalizing, so a non-string entry (null, number, etc.) in this free-text user-submitted field is skipped instead of throwing and blanking out all four Charts & Analytics charts via the outer catch handler. - Move the experienceTrend.length === 0 empty-state message inline (matching the pie chart's own conditional-render guard) instead of an early return, so the two bar charts and the pie chart still render when there's no experience-level data. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Shares VIBE_CODED_SERIES between submissionsTrend.js and ChartsAndAnalytics.jsx (mirroring the EXPERIENCE_LEVELS precedent) instead of hardcoding the strings twice, and adds a one-sentence caption noting vibe_coded is a newly-tracked field so the chart isn't misread as a real overnight trend reversal. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Extracts known technology names from the free-text tech_used_raw field via case-insensitive substring matching, with "Claude Code" checked and excluded first so it doesn't double-count toward the generic Claude/Anthropic API bucket. Shows the top 8 by project count as a horizontal bar chart, matching the existing keyword-frequency chart's style.

Reuses the fixed-order categorical hue palette already used in the charts (blue/orange/aqua/violet/magenta, gray for Uncategorized). Background and border are computed via color-mix() at low strength so each pill stays pale; text is mixed toward --text-h for a muted look instead of a fully saturated hue.

…chart Recharts' category axis auto-hides tick labels it calculates would overlap; interval={0} disables that, and the wider axis column gives longer labels like "Claude/Anthropic API" room to fit.

gitvelocity-reviewer · 2026-07-29T06:30:43Z

📊 Code Quality Score: 42/100

52 × 0.8 = 41.6 ≈ 42

Category	Score	Factors
🔭 Scope	13/20	12 files across components, CSS, and 4 utility modules; new user-facing charts; cross-cutting data→component→style layers
🏗️ Architecture	8/20	New utility modules follow established patterns; no new external dependencies; clean data/presentation separation; no new service boundaries
⚙️ Implementation	11/20	normalizeEndpoint longest-match-first algorithm; getTechCounts special-case stripping before pattern matching; CSS color-mix cascade; recharts animation workaround; endpoint deduplication per project
⚠️ Risk	5/20	Additive changes only; no data mutations, auth, or migrations; CSS margin-left hardcoded calculation is fragile but low blast radius
✅ Quality	13/15	Comprehensive tests >90% coverage on all new utility modules; edge cases covered (empty, non-string, boundary at 6, deduplication); good inline comments explaining non-obvious decisions
🔒 Perf / Security	2/5	Other bucket prevents unbounded pie chart rendering; no security concerns; no benchmarks or explicit perf work needed at this scale

Was this score accurate? 👍 Yes · 👎 No

_{Scored by GitVelocity · How are scores calculated?}

saengel

Overall, fantastic work! Some comments and learning opportunities - happy to review together when we meet next.

saengel · 2026-07-29T07:16:06Z


+// Fixed-order categorical hues; gray is reserved for the "Other" bucket and
+// is never one of the 6 identity colors.
+const TOOL_SLICE_COLORS = ['#2a78d6', '#eb6834', '#1baf7a', '#eda100', '#e87ba4', '#008300']


Do these match the Sefaria-specific color palette? Worth a quick check (for all of the colors used)

saengel · 2026-07-29T07:17:26Z

      </ResponsiveContainer>

      <h2>Submissions by experience level</h2>
+      {experienceTrend.length === 0 ? (


Each chart should be scoped into its own wrapper React component and JSX file, and then rendered here to make the code more readable, organized and reusable.

(Learn more about this practice here)

saengel · 2026-07-29T07:18:51Z

+                label={(props) =>
+                  props.index === experienceTrend.length - 1 ? (
+                    <text
+                      x={props.x + 6}


What's going on with the calculations here? Why is it necessary to add 6?

saengel · 2026-07-29T07:19:17Z

+
+      <h2>Most-used Sefaria API endpoints</h2>
+      {toolUsage.length === 0 ? (
+        <p>No endpoint data available yet.</p>


I'd change this text (everywhere on the page) to Data unavailable

saengel · 2026-07-29T07:19:33Z

+
+      <h2>Vibe-coded vs. not, past 12 months</h2>
+      <p>
+        "Vibe-coded" is a newly-tracked field, so earlier months may be undercounted or unreported rather than confirmed non-vibe-coded.


This is a helpful caveat

saengel · 2026-07-29T07:19:59Z

+        </ResponsiveContainer>
+      )}
+
+      <h2>Vibe-coded vs. not, past 12 months</h2>


More accurate to say tracked since July 2026 since we unfortunately don't have it explicitly from much earlier

saengel · 2026-07-29T07:20:42Z

@@ -1,3 +1,5 @@
+import { getCategoryColor } from '../utils/categories.js'
+


This is a great example of a small, composable component

saengel · 2026-07-29T07:21:50Z

@@ -0,0 +1,21 @@
+import { test } from 'node:test'


Wonderful that you added tests - always important. Let's reassess the best testing framework etc soon, we use Playwright on Sefaria-Project, might be worth aligning.

saengel · 2026-07-29T07:33:39Z

@@ -1,2 +1,2 @@
 :root {
  /* Sefaria brand palette */


I would double check, not sure Claude got it right. Let's also make this the one source of truth for the colors if possible and import from here as much as possible.

saengel · 2026-07-29T07:34:41Z

+// get counted toward the generic Claude/Anthropic API bucket.
+const CLAUDE_CODE_PATTERN = 'claude code'
+
+export const KNOWN_TECHNOLOGIES = [


This probably needs to be more robust to be useful in the future, might be a bit too fitted to the current data - but we can leave for now and remove in the future/adapt as needed.

Sefaria Intern and others added 11 commits July 28, 2026 13:09

feat: add sefaria API endpoint normalization util

4f86075

feat: add per-project deduped endpoint usage counting with top-6+Othe…

735394d

…r bucketing Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

feat: add pie chart of most-used Sefaria API endpoints

91f3d91

feat: add vibe-coded vs not-vibe-coded monthly trend util

63a82c3

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

feat: add vibe-coded vs not-vibe-coded trend chart

d06a866

feat: widen and left-align the search bar under the developers logo

79e5dc6

fix: force every technology label to render on the Technologies used …

6944815

…chart Recharts' category axis auto-hides tick labels it calculates would overlap; interval={0} disables that, and the wider axis column gives longer labels like "Claude/Anthropic API" room to fit.

ekoslow1-creator requested a review from saengel July 29, 2026 06:29

saengel requested changes Jul 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

3-5 New Charts - #4

3-5 New Charts#4
ekoslow1-creator wants to merge 11 commits into
mainfrom
feature/sc-46083/create-3-5-charts

ekoslow1-creator commented Jul 29, 2026

Uh oh!

gitvelocity-reviewer Bot commented Jul 29, 2026

Uh oh!

saengel left a comment

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

saengel Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,3 +1,5 @@
		import { getCategoryColor } from '../utils/categories.js'

Uh oh!

Conversation

ekoslow1-creator commented Jul 29, 2026

Uh oh!

gitvelocity-reviewer Bot commented Jul 29, 2026

📊 Code Quality Score: 42/100

Uh oh!

saengel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants