Skip to content

Feature/sc 46064/la thinking - #178

Open
yonadavGit wants to merge 6 commits into
mainfrom
feature/sc-46064/la-thinking
Open

Feature/sc 46064/la thinking#178
yonadavGit wants to merge 6 commits into
mainfrom
feature/sc-46064/la-thinking

Conversation

@yonadavGit

Copy link
Copy Markdown
Contributor

No description provided.

@yonadavGit
yonadavGit requested a review from nsantacruz July 27, 2026 13:28
@coolify-sefaria-github

coolify-sefaria-github Bot commented Jul 27, 2026

Copy link
Copy Markdown

The preview deployment for sefaria/ai-chatbot:server is ready. 🟢

Open app | Open Build Logs | Open Application Logs

Last updated at: 2026-07-29 09:53:45 CET

@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 29/100

48 × 0.6 = 28.8 → 29

Category Score Factors
🔭 Scope 12/20 8 files across frontend component, backend runner, orchestrator, contracts, i18n (2 locales), docs, env config; cross-cutting UX change touching multiple subsystems
🏗️ Architecture 10/20 Removes ProgressTrail component and associated state management; adds on_first_final_text_delta callback contract to SDK runner; clean simplification of loading state architecture
⚙️ Implementation 10/20 Moderate complexity in callback timing logic (3 call sites, saw_tool_use_message + first_final_text_delta_notified state tracking); timer-based thinking message cycling is straightforward; normalizeHostname hoisting dependency is subtle
⚠️ Risk 7/20 Removes existing tool history display feature; normalizeHostname called before definition (relies on function hoisting); thinking messages are now decorative rather than informative; otherwise manageable rollback
✅ Quality 7/15 One new test added covering primary use case; docs updated with env var instructions; i18n updated for en+he; missing tests for no-tool-use path, None callback guard, and orchestrator synthesis timing
🔒 Perf / Security 2/5 VITE_SEFARIA_HOSTNAMES allowlist adds configurable hostname security; normalizeHostname handles malformed input gracefully

Was this score accurate? 👍 Yes · 👎 No

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant