Fix bug with opening sources links - #3565
Open
saengel wants to merge 1 commit into
Open
Conversation
📊 Code Quality Score: 1/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes navigation for “sources” search result cards when clicks are handled by in-app navigation (e.g., ReaderApp.handleNavigationClick / openPanel), by ensuring the click handler receives a proper text ref string instead of a URL path with query params.
Changes:
- Pass the underlying text ref (
tref) through the sources-mode search result card props. - Update
SearchResultCardto prefertrefoverhrefwhen invokingonResultClick, while keepinghrefas the actual anchor URL for normal navigation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
static/js/SearchResultList.jsx |
Adds tref: s.ref to the sources-mode card props so the card can navigate using a real ref string. |
static/js/SearchResultCard.jsx |
Accepts tref and uses it for onResultClick(tref ?? href, ...); updates propTypes accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stevekaplan123
left a comment
stevekaplan123
left a comment
Member
There was a problem hiding this comment.
I'm wondering why we need both tref and href. Is it possible we only need the tref?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where returned sources card title links wouldn't resolve.
Code Changes
Passing the ref through to the search result card