feat: hide LA promo banner on authentication screens

[dcschreiber]

(Claude and Codex writing on Daniel's behalf)

What

Hides the Library Assistant promo banner (ChatbotExperimentBanner) on authentication and password-recovery screens:

• /login
• /register
• the complete /password/reset/... route family

Shortcut story: https://app.shortcut.com/sefaria/story/46176

Why

These screens should remain focused on authentication or account recovery. The Library Assistant already opens automatically after successful login or registration, so promoting it there is redundant.

How

The banner keeps a small, product-specific path policy local to SiteWideBanner.jsx. It gets the path from the existing SSR-safe Sefaria.util.currentPath(), resolves it with the native URL parser against Sefaria.getModuleURL() (the configured active-module/interface-language domain), and checks one array of excluded route roots with a segment boundary. This covers the password-reset family while leaving unrelated paths such as /password/resetting eligible.

There is no existing reusable frontend auth-path classifier. The broader headerMode abstraction was deliberately not used because it also covers ordinary static/about pages where sitewide banners remain valid.

How tested

Focused Jest coverage verifies:

• login and registration, including trailing slashes and query strings
• reset form, confirmation, done, and complete paths
• similarly named non-auth paths are not accidentally excluded

npx jest static/js/tests/siteWideBanner.test.js --runInBand --no-watchman --roots static/js __mocks__ passes: 23 tests.

[gitvelocity-reviewer]

📊 Code Quality Score: 7/100

26 × 0.25 = 6.5, rounded to 7

Category	Score	Factors
🔭 Scope	4/20	2 files, single component, localized banner suppression logic
🏗️ Architecture	3/20	Extracts small utility function, exports it for testability; no new patterns or dependencies
⚙️ Implementation	5/20	Path normalization with regex (split on [?#], strip trailing slash, fallback to /); early return guard after hooks
⚠️ Risk	3/20	Additive change, easily reversible, no data or API changes; minor case-sensitivity assumption
✅ Quality	10/15	30-line test file covering exact matches, trailing slashes, query strings, hashes, and non-excluded paths; clear inline comment explaining rationale
🔒 Perf / Security	1/5	No performance or security concerns; minimal regex on every render is negligible

Was this score accurate? 👍 Yes · 👎 No

_{Scored by GitVelocity · How are scores calculated?}