Skip to content

ci: parallel publish helm charts to oci - #3554

Open
BrendanGalloway wants to merge 1 commit into
masterfrom
oci-helm
Open

ci: parallel publish helm charts to oci#3554
BrendanGalloway wants to merge 1 commit into
masterfrom
oci-helm

Conversation

@BrendanGalloway

Copy link
Copy Markdown
Contributor

Description

A brief description of the PR

Code Changes

The following changes were made to the files below

Notes

Any additional notes go here

@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 7/100

27 × 0.25 = 6.75, rounded to 7

Category Score Factors
🔭 Scope 5/20 Two CI workflow files, single CI/CD subsystem, no new public APIs or external service integrations beyond GCP auth
🏗️ Architecture 4/20 Adds publishing step to existing pipelines; follows existing patterns; no new abstractions or service boundaries
⚙️ Implementation 5/20 Standard GitHub Actions YAML; Workload Identity Federation auth pattern; moderate complexity for CI config; inconsistent step ID references between files
⚠️ Risk 8/20 Touches production GCP service account and Workload Identity; inconsistent secret names (PROD_GKE_PROJECT vs PROD_GKE_PROJECT_ID) could cause silent failures; access token passed as CLI arg
✅ Quality 3/15 No tests (expected for CI); minimal inline comments; code duplicated across two workflow files; no reusable workflow abstraction
🔒 Perf / Security 2/5 Uses Workload Identity Federation (keyless, good); access token exposed via -p flag rather than --password-stdin; token is step output not declared secret so may not be masked in logs

Was this score accurate? 👍 Yes · 👎 No

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant